Skip to content

Make hyperlinks clickable in markdown previews #5035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobiasKaminsky merged 5 commits into from
Jan 6, 2020
Merged

Make hyperlinks clickable in markdown previews #5035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5f70ea6
Make hyperlinks clickable in markdown previews
AndyScherzinger Dec 19, 2019
a15f724
Make hyperlinks clickable in markdown previews
AndyScherzinger Dec 19, 2019
154b9af
adjusted to master
tobiasKaminsky Jan 6, 2020
a680697
Removed unneeded try/catch
tobiasKaminsky Jan 6, 2020
5fce6ca
Removed unneeded try/catch
tobiasKaminsky Jan 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/com/nextcloud/client/di/ComponentsModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
import com.owncloud.android.ui.preview.PreviewImageActivity;
import com.owncloud.android.ui.preview.PreviewImageFragment;
import com.owncloud.android.ui.preview.PreviewMediaFragment;
import com.owncloud.android.ui.preview.PreviewTextFileFragment;
import com.owncloud.android.ui.preview.PreviewTextFragment;
import com.owncloud.android.ui.preview.PreviewTextStringFragment;
import com.owncloud.android.ui.preview.PreviewVideoActivity;
Expand Down Expand Up @@ -139,6 +140,8 @@ abstract class ComponentsModule {
@ContributesAndroidInjector abstract ContactListFragment chooseContactListFragment();
@ContributesAndroidInjector abstract PreviewMediaFragment previewMediaFragment();
@ContributesAndroidInjector abstract PreviewTextFragment previewTextFragment();

@ContributesAndroidInjector abstract PreviewTextFileFragment previewTextFileFragment();
@ContributesAndroidInjector abstract PreviewTextStringFragment previewTextStringFragment();
@ContributesAndroidInjector abstract PhotoFragment photoFragment();

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2371,7 +2371,7 @@ public void startTextPreview(OCFile file, boolean showPreview) {
args.putBoolean(EXTRA_SEARCH, searchOpen);
args.putString(EXTRA_SEARCH_QUERY, searchQuery);
Fragment textPreviewFragment = Fragment.instantiate(getApplicationContext(),
PreviewTextFragment.class.getName(), args);
PreviewTextFileFragment.class.getName(), args);
setSecondFragment(textPreviewFragment);
updateFragmentsVisibility(true);
updateActionBarTitleAndHomeButton(file);
Expand Down
Loading