Skip to content

Conversation

@backportbot-nextcloud
Copy link

backport of #5122

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
           

See the complete overview on Codacy

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12221.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Lint

Typestable-3.10PR
Warnings7474
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings107
Security Warnings44
Dodgy code Warnings139
Total414

SpotBugs (stable-3.10)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings107
Security Warnings44
Dodgy code Warnings139
Total414

@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #5147 into stable-3.10 will decrease coverage by 0.02%.
The diff coverage is 71.42%.

@@                Coverage Diff                @@
##             stable-3.10    #5147      +/-   ##
=================================================
- Coverage          17.71%   17.69%   -0.03%     
  Complexity             3        3              
=================================================
  Files                392      392              
  Lines              33116    33120       +4     
  Branches            4651     4653       +2     
=================================================
- Hits                5867     5861       -6     
- Misses             26296    26304       +8     
- Partials             953      955       +2
Impacted Files Coverage Δ Complexity Δ
.../nextcloud/client/onboarding/FirstRunActivity.java 38.04% <100%> (+0.68%) 0 <0> (ø) ⬇️
...com/owncloud/android/ui/activity/BaseActivity.java 37.63% <66.66%> (+0.96%) 0 <0> (ø) ⬇️
...d/android/operations/GetCapabilitiesOperation.java 75% <0%> (-12.5%) 0% <0%> (ø)
...om/owncloud/android/utils/FileSortOrderByName.java 14.28% <0%> (-2.86%) 0% <0%> (ø)
.../java/com/owncloud/android/utils/DisplayUtils.java 24.89% <0%> (-0.85%) 0% <0%> (ø)
...oud/android/operations/RefreshFolderOperation.java 58.94% <0%> (-0.41%) 0% <0%> (ø)
...ncloud/android/ui/fragment/OCFileListFragment.java 25.2% <0%> (-0.41%) 0% <0%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 20.12% <0%> (-0.24%) 0% <0%> (ø)
...oud/android/ui/activity/SyncedFoldersActivity.java 26.81% <0%> (+0.5%) 0% <0%> (ø) ⬇️

@tobiasKaminsky tobiasKaminsky merged commit a289346 into stable-3.10 Jan 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the backport/5122/stable-3.10 branch January 10, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants