Ignore CHANGELOG.md while generating changelogs #5791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I heard you liked changelogs, so I put a changelog in your changelog... or something. How meta. Signed-off-by: AJ Jordan <alex@strugee.net>
strugee
force-pushed
the
ignore-changelog-in-changelogs
branch
from
39bc75b to
d31dd61
Compare
tobiasKaminsky
approved these changes
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I heard you liked changelogs, so I put a changelog in your changelog... or something. How meta.
Full disclosure, I didn't test this because I couldn't quite figure out how to get it to generate the changelog in the latest F-Droid build (which prompted me to write this patch), and it was so trivial I figured it wasn't worth bothering with.
Testing
Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.
unit tests
instrumented tests
UI tests