Skip to content

Fixed account extra argument passed to OperationsService when starting sync #6023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tobiasKaminsky merged 1 commit into from
May 11, 2020
Merged

Fixed account extra argument passed to OperationsService when starting sync #6023

tobiasKaminsky merged 1 commit into from
May 11, 2020

Conversation

@ezaquarii
Copy link
Collaborator

@ezaquarii ezaquarii commented May 7, 2020 •
edited
Loading

Fixes #6020

@ezaquarii ezaquarii mentioned this pull request May 7, 2020
Closed
@ezaquarii
Copy link
Collaborator Author

ezaquarii commented May 7, 2020

@tobiasKaminsky This should be also backported into stable.

@ezaquarii
Copy link
Collaborator Author

ezaquarii commented May 7, 2020

/backport to stable-3.12

@ezaquarii ezaquarii linked an issue May 7, 2020 that may be closed by this pull request
App crash #6020
Closed
@ezaquarii
Fixed account extra argument passed to OperationsService when startin…
f9c233f 
…g sync

Fixes #6020

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
@ezaquarii ezaquarii force-pushed the ezaquarii/fix-account-argument-passed-to-operations-service branch from 184df9a to f9c233f Compare May 7, 2020 21:02
@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented May 7, 2020

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13849.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented May 7, 2020

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/13848-IT

@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented May 7, 2020

Codacy

377

Lint

TypemasterPR
Warnings9494
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings68
Internationalization Warnings9
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings75
Security Warnings44
Dodgy code Warnings138
Total373

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings68
Internationalization Warnings9
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings75
Security Warnings44
Dodgy code Warnings138
Total373

@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented May 7, 2020

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/13849-IT

@ezaquarii ezaquarii mentioned this pull request May 8, 2020
Closed
@ezaquarii ezaquarii linked an issue May 8, 2020 that may be closed by this pull request
Android app crash when syncing folder #6028
Closed
@ezaquarii ezaquarii mentioned this pull request May 10, 2020
Closed
@ezaquarii ezaquarii linked an issue May 10, 2020 that may be closed by this pull request
Crash on Android 10 while syncing an folder #6038
Closed
@tobiasKaminsky tobiasKaminsky merged commit e3d7145 into master May 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the ezaquarii/fix-account-argument-passed-to-operations-service branch May 11, 2020 13:32
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 11, 2020
Merged
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.13.0 milestone May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 3.13.0

Development

Successfully merging this pull request may close these issues.

Crash on Android 10 while syncing an folder Android app crash when syncing folder App crash

5 participants

@ezaquarii @nextcloud-android-bot @AndyScherzinger @tobiasKaminsky