Skip to content

[stable-3.12] Fix wrong extra_account, which used user instead of account #6079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndyScherzinger merged 1 commit into from
May 15, 2020
Merged

[stable-3.12] Fix wrong extra_account, which used user instead of account #6079

AndyScherzinger merged 1 commit into from
May 15, 2020

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented May 15, 2020 •
edited by AndyScherzinger
Loading

backport of #6075

Fix #6070
Fix #6077

@tobiasKaminsky @backportbot
Fix wrong extra_account, which used user instead of account
3bb428d 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud App 3.12.0 milestone May 15, 2020
@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented May 15, 2020

Unit test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented May 15, 2020

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13980.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented May 15, 2020

Lint

Typestable-3.12PR
Warnings9494
Errors11

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings69
Internationalization Warnings10
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings77
Security Warnings44
Dodgy code Warnings142
Total381

SpotBugs (stable-3.12)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings69
Internationalization Warnings10
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings77
Security Warnings44
Dodgy code Warnings142
Total381

@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented May 15, 2020

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/13980-IT

@AndyScherzinger AndyScherzinger merged commit f847e73 into stable-3.12 May 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the backport/6075/stable-3.12 branch May 15, 2020 07:05
@AndyScherzinger AndyScherzinger mentioned this pull request May 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@ezaquarii ezaquarii Awaiting requested review from ezaquarii

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 3.12.0

Development

Successfully merging this pull request may close these issues.

3 participants

@nextcloud-android-bot @AndyScherzinger @tobiasKaminsky