HotFix master branch: Set fixed lib version #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
FYI the display name change in the lib simply adds the possibility to retrieve the full name, we haven't utilized this yet but I will asap for the drawer implementation but that isn't a blocking issue so we can still release the app whenever we think it is ready and can ship full name display any time later :) |
Member
|
👍 👍 we always should depend on stable version not repos snapshot |
Member
Author
|
That's true! Absolutely 👍 |
Member
|
👍 |
Member
Author
|
@tobiasKaminsky why keep it mostly the same? We could create new versions for new features which would only be used on a feature branch and push the new version/dependency with the feature PR to master. Not sure I got your point :S |
Member
|
Yeah, I think I was confused. Please forget my idea ;) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason jitpack is not refreshing the snapshot build so the branch won't build thus I created a lib release 1.0.1 and set the dependency to 1.0.1 instead of -SNAPSHOT
ATM This is necessary in order to get master to compile again. Sorry for any inconvenience :(