Fix crash when creating client #6214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Member
Author
|
/backport to stable-3.12 |
Collaborator
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14352.apk |
Collaborator
Codacy390Lint
SpotBugs (new)
SpotBugs (master)
|
Collaborator
|
master-IT test failed, but no output was generated. Maybe a preliminary stage failed. |
Collaborator
Collaborator
|
stable-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
Collaborator
Collaborator
I think that this UI thread issue stung me in #6048 and is the sole reason why I had to introduce |
AndyScherzinger
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6212
This is not an ideal solution, but it works for now.
I will open & assign an issue to me, that all client creations must be centralized & non blocking, so that they can used on ui thread.
Signed-off-by: tobiasKaminsky tobias@kaminsky.me
Testing
Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.
unit tests
instrumented tests
UI tests