Skip to content

ExApp UI Adjustments (Part2) #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bigcat88 merged 9 commits into from
Dec 3, 2023
Merged

ExApp UI Adjustments (Part2) #137

bigcat88 merged 9 commits into from
Dec 3, 2023

Conversation

@bigcat88
Copy link
Member

@bigcat88 bigcat88 commented Dec 3, 2023 •
edited
Loading

Changes proposed in this PR(first part is here #135):

CI:

  • added Oracle CI test, as previous PR created a new error with Oracle DB due to missing tests
  • TopMenu: icon_url -> icon

Bugs:

  • do not spam error into log file in getExAppFileAction, getExAppMenuEntry
  • Oracle fix for FileAction entry

@bigcat88 bigcat88 requested a review from andrey18106 December 3, 2023 20:04
@bigcat88 bigcat88 marked this pull request as ready for review December 3, 2023 20:13
@bigcat88 bigcat88 merged commit 42cc56d into main Dec 3, 2023
@bigcat88 bigcat88 deleted the ui-fixes-adjustments branch December 3, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrey18106 andrey18106 andrey18106 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bigcat88 @andrey18106