Skip to content

ExApp proxy adjustments and fixes #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bigcat88 merged 9 commits into from
Jun 10, 2024
Merged

ExApp proxy adjustments and fixes #296

bigcat88 merged 9 commits into from
Jun 10, 2024

Conversation

@andrey18106
Copy link
Contributor

@andrey18106 andrey18106 commented May 22, 2024 •
edited
Loading

This PR made a few changes to ExApp proxy:

  1. Fix Get requests proxy to preserve the url params
  2. Add pass of cookies to the ExApp with request
  3. Fixes Proxy work with multipart requests and files using separate internal version of requestToExApp with slightly adjusted handling of query and body params
  4. Remove default caching for json requests

@andrey18106 andrey18106 requested a review from bigcat88 May 22, 2024 17:47
@andrey18106
adjust proxy to pass cookies to ExApp
a1136f4 
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
@andrey18106 andrey18106 force-pushed the adjustments-ui-integration branch from 03750cd to a1136f4 Compare May 22, 2024 18:33
bigcat88
bigcat88 approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not check myself, but looks good

@andrey18106
proxy fixes after local tests
fa5e9f6 
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
@andrey18106 andrey18106 requested a review from bigcat88 May 23, 2024 16:20
@andrey18106
calm psalm
060efda 
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
@andrey18106
php-cs
5461896 
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
@andrey18106 andrey18106 changed the title adjust proxy to pass cookies to ExApp ExApp proxy adjustments and fixes May 24, 2024
andrey18106 and others added 5 commits June 1, 2024 16:27
@andrey18106
set http_errors to false, do not throw exception
127b830 
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
@bigcat88
allow proxying of "apps/app_api/proxy/ex_app_id/" (root url for ExApp)
e3351eb 
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88
Merge branch 'main' into adjustments-ui-integration
f16df39
@bigcat88
fixed CI
4429be4 
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88
UIProxy: do not cache "application/x-tar" mimetype
80878b1 
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@bigcat88 bigcat88 merged commit 0a80c68 into main Jun 10, 2024
@bigcat88 bigcat88 deleted the adjustments-ui-integration branch June 10, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bigcat88 bigcat88 bigcat88 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrey18106 @bigcat88