optimization: system flag and ex_app_users removal #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
bigcat88
reviewed
Jul 10, 2024
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
bigcat88
approved these changes
Jul 11, 2024
Member
bigcat88
left a comment
bigcat88
left a comment
There was a problem hiding this comment.
Need additional manual testing/check with providing info.xml without system flag - to see if all is ok,- but looks good to me.
Release with this anyway will be on the next week, so we will have plenty time to test it locally and see that it is not breaking anything during development of ExApps
andrey18106
changed the title
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
bigcat88
added a commit
to cloud-py-api/nc_py_api
that referenced
this pull request
Jul 12, 2024
We are making ExApps more like usual PHP Apps for Nextcloud. Now any ExApp is allowed to impersonate any user, no need "system" flag for this. Reference: nextcloud/app_api#323 Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The system flag and extra table for that
ex_app_usersis removed to optimize database usage and simplify the system logic.