-
Notifications
You must be signed in to change notification settings - Fork 3
Replace NcDateTimePicker with NcDateTimePickerNative
#177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pytal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than translations
|
This library doesn't have any built-in l10n support at all. It supposes a user to pass all localized strings as props (like Simple solution Add new props aka (dayName) => t('dav', 'Pick a start time for {dayName}', { dayName })And then it can be used as :label="l10nStartPickerLabel(day.displayName)"Complex solution Set up l10n for the library. Example: https://github.com/nextcloud-libraries/nextcloud-password-confirmation Alternative solution Move this component to the |
8c1ebec to
1f8e384
Compare
st3iny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works. Thanks :)
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com> Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
1f8e384 to
c5649e3
Compare
Replace
NcDateTimePickerwithNcDateTimePickerNativeFixes nextcloud/server#40699
Esc) via replacing components toNcDateTimePickerNativeFixes nextcloud/server#40696
🖼️ Screenshots