Added rename addressbook functionality. #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irgendwie
added
3. to review
irgendwie
force-pushed
the
rename-addressbook
branch
from
ccf817e to
c34b4e9
Compare
Member
|
As you can see from the second screenshot, it’s a bit confusing with the »Address book name« input field. It would be good to put the »Add new address book« function behind a button to clear up the confusion, also in general when you open the settings. cc @skjnldsv @irgendwie @nextcloud/contacts what do you think? |
Henni
approved these changes
Apr 19, 2017
skjnldsv
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #101
Adds the possibility to rename addressbooks and can be found in the settings menu.