Skip to content

fix: show address book in read only mode #4949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SebastianKrupinski merged 1 commit into from
Jan 5, 2026
Merged

fix: show address book in read only mode #4949

SebastianKrupinski merged 1 commit into from
Jan 5, 2026
+1 −1

Conversation

@SebastianKrupinski
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski commented Dec 29, 2025

Issue

  • When you have a personal address book and a system address book there is no way to know which address book the contact is in because the address book property is not visible

Resolution

  • Always show which address book the contact is in, when is ready only view and hide it in edit mode if there is only one usable address book

@SebastianKrupinski
fix: show address book in read only mode
249654f 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski SebastianKrupinski self-assigned this Dec 29, 2025
@SebastianKrupinski SebastianKrupinski added the 3. to review Waiting for reviews label Dec 29, 2025
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Dec 29, 2025
@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@SebastianKrupinski SebastianKrupinski merged commit 63d9905 into main Jan 5, 2026
45 checks passed
@SebastianKrupinski SebastianKrupinski deleted the fix/show-addressbook-in-read-only-mode branch January 5, 2026 14:23
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Jan 5, 2026
@SebastianKrupinski
Copy link
Contributor Author

SebastianKrupinski commented Jan 5, 2026

/backport to stable8.2

@backportbot backportbot bot mentioned this pull request Jan 5, 2026
Merged
@SebastianKrupinski
Copy link
Contributor Author

SebastianKrupinski commented Jan 5, 2026

/backport to stable7.3

@backportbot backportbot bot mentioned this pull request Jan 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hamza221 hamza221 hamza221 approved these changes

@GVodyanov GVodyanov Awaiting requested review from GVodyanov GVodyanov is a code owner

Assignees

@SebastianKrupinski SebastianKrupinski

Labels

3. to review Waiting for reviews

Projects

💌 📅 👥 Groupware team
Status: ☑️ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SebastianKrupinski @hamza221