Archive boards #133

juliusknorr · 2017-05-16T10:15:15Z

Signed-off-by: Julius Härtl jus@bitgrid.net

get board permissions on boardlist
Apply archive filter to the sidebar
Add unit tests

artemanufrij · 2017-05-16T18:09:02Z

@juliushaertl It's not possible to move a board from archive into standard view. After click on "..." board opens.

artemanufrij · 2017-05-17T18:03:47Z

@juliushaertl after moving board into archive it stays in the navigation bar. I guess it should be removed from navigationbar...

codecov · 2017-05-18T08:10:15Z

Codecov Report

Merging #133 into master will increase coverage by 3.78%.
The diff coverage is 66.93%.

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
+ Coverage   72.34%   76.12%   +3.78%     
==========================================
  Files          32       33       +1     
  Lines         846      955     +109     
==========================================
+ Hits          612      727     +115     
+ Misses        234      228       -6

juliusknorr · 2017-05-18T09:11:31Z

@artemanufrij This is ready to test. Only unit tests are missing for some new methods.

artemanufrij

after unarchive a board deck stays in "archive"-view but shows only "unarchived" boards.
It shouldn't be possible to create a new board in archive-view

artemanufrij · 2017-05-28T13:32:58Z

position of context menu is broken:

artemanufrij

some comments:

it's not possible to remove a board in default view
deleting doesn't work in archive view
PS: restore works
position of context menu is broken (see screenshot) PS: style.css has conflicts

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Signed-off-by: Artem Anufrij <artem.anufrij@live.de>

Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr · 2017-06-08T19:04:27Z

@artemanufrij @pixelipo Please review.

This also fixes #85

artemanufrij · 2017-06-08T19:18:40Z

@juliushaertl
Undo works fine for board but not for card or stack. --> it's ok for me

Board will be permanent deleted after 5 minutes.

artemanufrij

works as expected (discussed in irc-channel)...
Test cases:

move board into archive 👍
move board from archive into default view 👍
delete board 👍
undo deleting operation 👍

juliusknorr · 2017-06-08T20:45:51Z

Thanks for testing 👍 I'll merge this now so we have it in todays nightly builds for further testing.

pixelipo · 2017-06-08T19:40:21Z

css/style.css

+}
+
+.app-navigation-entry-utils-menu-button {
+	display: block !important;


I think this can safely be deleted

pixelipo · 2017-06-08T19:45:42Z

css/style.css

 */

+.app-navigation-entry-menu ul {
+	flex-direction: row;


According to @jancborchardt icons should be stacked vertically (with a label next to them):

#121 (comment)

pixelipo · 2017-06-08T19:56:25Z

css/style.css

-	padding-left: 4px;
+	border-radius:3px;
+	flex-direction: row;
+	min-width: 240px;


can it be larger anyway? Maybe width: 100%; would make more sense here.

Edit: It can, in the table. However, the question then is should it really grow? Setting a fixed width at 240px and removing flex-grow on line 720 would make both colorlists equal in size.

Not sure about that, since we have 2 places with different width using this.

pixelipo · 2017-06-08T19:57:43Z

css/style.css

 */

 .colorselect {
 	overflow: hidden;


Is there a case where this container overflows?

no, i think that is a leftover from using floats before using flexbox with this PR.

pixelipo · 2017-06-08T20:02:26Z

css/style.css

 }

 .colorselect .selected {
+	background-image: url(../../../core/img/actions/checkmark.svg);


It owuld be better to move his to a new class icon-selected or icon-checkmark. Then it can be reused. Also, next two lines could be removed.

P.S. do we need ../../..? on my setup(s), url(/core/img/actions/checkmarks.svg) works fine.

/core/ will not work on setups where nextcloud is running inside of a subdirectory, so the ../../../ are needed.

but classes like icon-selected and icon-selected-dark makes sense.

pixelipo · 2017-06-08T20:02:44Z

css/style.css

+}
+
+.colorselect .dark.selected {
+	background-image: url(../../../core/img/actions/checkmark-white.svg);


same as above

pixelipo · 2017-06-08T20:15:49Z

css/style.css

+	position: relative;
+}
+
+.popovermenu ul {


This style already exists in core css that is served alongside, so perhaps it;s not needed?

.bubble ul, .app-navigation-entry-menu ul, .popovermenu ul { display: flex !important; flex-direction: column; }

👍 But i need to check that.

pixelipo · 2017-06-08T20:18:08Z

css/style.css

 	width: 50%;
+}

+#boardlist tr.deleted td * {


why not just change the opacity of the whole row with #boardlist tr.deleted { ?

It will also change the opacity of the border that separates the lines, that looked a bit odd. 😉

pixelipo · 2017-06-08T20:46:58Z

img/deck.svg

@@ -0,0 +1 @@
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512"><path d="M432.3 448.1h-348c-13.2 0-24-10.8-24-24V264.6c0-13.2 10.8-24 24-24h348c13.2 0 24 10.8 24 24v159.5c0 13.2-10.8 24-24 24zM380.4 89.8H127.8c-7.7 0-14-6.3-14-14v-6.3c0-7.7 6.3-14 14-14h252.6c7.7 0 14 6.3 14 14v6.3c0 7.7-6.3 14-14 14zm19.4 61.8H110.6c-7.7 0-14-6.3-14-14v-6.3c0-7.7 6.3-14 14-14h289.2c7.7 0 14 6.3 14 14v6.3c0 7.7-6.3 14-14 14zm21.6 61.4H94.6c-7.7 0-14-6.3-14-14v-6.3c0-7.7 6.3-14 14-14h326.8c7.7 0 14 6.3 14 14v6.3c0 7.7-6.3 14-14 14z"/></svg>


It would be good to keep this in line with the other Nextcloud icons. I will commit an optimized version of the icon to this PR - I hope you don't mind 😉

Since you merged before my review, I created a new PR #175

Sure. feel free to open a new PR, since this one is already merged 🙈

juliusknorr · 2017-06-08T21:12:43Z

@pixelipo Thanks for the comments on the css changes. I'll try to address those in a follow up PR tomorrow.

jancborchardt · 2017-06-09T14:43:41Z

Awesome work by you all on the Deck app by the way! :) I want to check it out more too, and I would actually use it for my Tasks if it would use the Nextcloud dav backend (so I can simply switch between Deck and the Tasks app whenever I like :)

juliusknorr · 2017-06-10T06:41:45Z

@jancborchardt Thanks for checking it out :) Integration is also one of my main goals but until now I have not come up with a satisfying solution on how to integrate it with the dav backend. I'll look deeper into this after the next version is released.

LunaUrsa · 2017-06-25T16:05:00Z

I appreciate all the work done here. Is there any thought about making Decks archivable the way Boards and Slides can be?

juliusknorr · 2017-06-27T10:10:19Z

@TeknoShamin Yes, I think archiving stacks would make sense as well. Can you open a new issue for that?

juliusknorr force-pushed the archive-boards branch from 63600d9 to 2938e14 Compare May 17, 2017 17:51

juliusknorr force-pushed the archive-boards branch from 2938e14 to f5e65c5 Compare May 18, 2017 08:10

juliusknorr added this to the 0.2.0 milestone May 18, 2017

artemanufrij self-requested a review May 18, 2017 10:52

artemanufrij reviewed May 18, 2017

View reviewed changes

juliusknorr force-pushed the archive-boards branch 2 times, most recently from 9e5caaf to eef2b7c Compare May 28, 2017 13:16

juliusknorr force-pushed the archive-boards branch 7 times, most recently from ffdd615 to 5a20b04 Compare May 29, 2017 07:55

artemanufrij reviewed May 29, 2017

View reviewed changes

juliusknorr added 10 commits June 8, 2017 19:35

Archive boards

8c04ea8

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Fix unit tests for board archiving

90eb9ce

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Fix getting permissions and active indicator

247b4dd

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Keep deleted boards for a while and delete with cron

2c63bfb

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Fix varius small issues

f7b69d9

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Add unit tests

06e41f5

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Fix missing card actions

f5dc4ac

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Fix stateParam changes

c758637

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Fix adding new boards in the sidebar

57f74c9

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Add more unit testing

19a9080

Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr added 2 commits June 8, 2017 19:35

Fix codacy errors

4623688

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Allow force delete to have a clean test env after creating boards

3062c82

Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr force-pushed the archive-boards branch from ca589b7 to 61f5ded Compare June 8, 2017 17:36

artemanufrij and others added 3 commits June 8, 2017 20:52

fixed_context_menu_position

727a335

Signed-off-by: Artem Anufrij <artem.anufrij@live.de>

add_delete_menu_in_default_view

034ac5e

Signed-off-by: Artem Anufrij <artem.anufrij@live.de>

Some minor fixes

68b2025

Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr force-pushed the archive-boards branch from 61f5ded to 68b2025 Compare June 8, 2017 18:53

juliusknorr added 3. to review enhancement labels Jun 8, 2017

juliusknorr requested a review from pixelipo June 8, 2017 19:03

juliusknorr changed the title ~~WIP: Archive boards~~ Archive boards Jun 8, 2017

x9t9 mentioned this pull request Jun 8, 2017

Review Overall design and CSS strategy - implement FLEX #128

Closed

1 task

juliusknorr mentioned this pull request Jun 8, 2017

ER: Minimized Left Panel #123

Closed

artemanufrij approved these changes Jun 8, 2017

View reviewed changes

juliusknorr merged commit 48842dd into master Jun 8, 2017

juliusknorr deleted the archive-boards branch June 8, 2017 20:46

This was referenced Jun 8, 2017

Ability to archive boards #70

Closed

Provide undo-operation on delete #85

Closed

pixelipo reviewed Jun 8, 2017

View reviewed changes

matejak mentioned this pull request Aug 3, 2021

Deleted deck cards are being kept in deleted items forever #2927

Closed

		@@ -0,0 +1 @@
		<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512"><path d="M432.3 448.1h-348c-13.2 0-24-10.8-24-24V264.6c0-13.2 10.8-24 24-24h348c13.2 0 24 10.8 24 24v159.5c0 13.2-10.8 24-24 24zM380.4 89.8H127.8c-7.7 0-14-6.3-14-14v-6.3c0-7.7 6.3-14 14-14h252.6c7.7 0 14 6.3 14 14v6.3c0 7.7-6.3 14-14 14zm19.4 61.8H110.6c-7.7 0-14-6.3-14-14v-6.3c0-7.7 6.3-14 14-14h289.2c7.7 0 14 6.3 14 14v6.3c0 7.7-6.3 14-14 14zm21.6 61.4H94.6c-7.7 0-14-6.3-14-14v-6.3c0-7.7 6.3-14 14-14h326.8c7.7 0 14 6.3 14 14v6.3c0 7.7-6.3 14-14 14z"/></svg>

Archive boards #133

Archive boards #133

Uh oh!

Conversation

juliusknorr commented May 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

artemanufrij commented May 16, 2017

Uh oh!

artemanufrij commented May 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

juliusknorr commented May 18, 2017

Uh oh!

artemanufrij left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

artemanufrij commented May 28, 2017

Uh oh!

artemanufrij left a comment

Choose a reason for hiding this comment

Uh oh!

juliusknorr commented Jun 8, 2017

Uh oh!

artemanufrij commented Jun 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

artemanufrij left a comment

Choose a reason for hiding this comment

Uh oh!

juliusknorr commented Jun 8, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

juliusknorr Jun 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

juliusknorr commented Jun 8, 2017

Uh oh!

jancborchardt commented Jun 9, 2017

Uh oh!

juliusknorr commented Jun 10, 2017

juliusknorr commented May 16, 2017 •

edited

Loading

artemanufrij commented May 17, 2017 •

edited

Loading

codecov bot commented May 18, 2017 •

edited

Loading

artemanufrij left a comment •

edited

Loading

artemanufrij commented Jun 8, 2017 •

edited

Loading

juliusknorr Jun 8, 2017 •

edited

Loading