fixed tooltip bug and closes #1679 #1713
Conversation
Signed-off-by: Ishant <ishantgupta777@gmail.com>
|
Ideally the ActionsButton component from https://github.com/nextcloud/nextcloud-vue should just show a v-tooltip for single actions, but I'm fine with this as a temporary workaround. |
src/components/boards/BoardItem.vue
Outdated
| </div> | ||
| <div class="board-list-avatars-cell"> | ||
| <Avatar :user="board.owner.uid" class="board-list-avatar" /> | ||
| <Avatar :user="board.owner.uid" :title="board.owner.displayname" class="board-list-avatar" /> |
There was a problem hiding this comment.
I think the tooltip here is coming from the parent element and the Avatar has a proper v-tooltip usage. My suggestion would be to just set an empty title attribute on the parent div (.board-list-avatars-cell)
| <button v-if="board.acl.length === 0" | ||
| class="icon-shared" | ||
| style="opacity: 0.3" | ||
| :title="'Share'" |
There was a problem hiding this comment.
Please make those translatable.
There was a problem hiding this comment.
@juliushaertl I have done the changes, please have a look.
@ishantgupta777 can you do so? |
Sure sir, I am doing the changes. |
Signed-off-by: Ishant <ishantgupta777@gmail.com>
src/components/boards/BoardItem.vue
Outdated
| <div class="board-list-avatars-cell" :title="''"> | ||
| <Avatar :user="board.owner.uid" :title="board.owner.displayname" class="board-list-avatar" /> |
There was a problem hiding this comment.
| <div class="board-list-avatars-cell" :title="''"> | |
| <Avatar :user="board.owner.uid" :title="board.owner.displayname" class="board-list-avatar" /> | |
| <div class="board-list-avatars-cell" title=""> | |
| <Avatar :user="board.owner.uid" :display-name="board.owner.displayname" class="board-list-avatar" /> |
src/components/boards/BoardItem.vue
Outdated
| <Avatar v-for="user in limitedAcl" | ||
| :key="user.id" | ||
| :user="user.participant.uid" | ||
| :title="user.participant.displayname" |
There was a problem hiding this comment.
| :title="user.participant.displayname" | |
| :display-name="user.participant.displayname" |
| <button v-if="board.acl.length === 0" | ||
| class="icon-shared" | ||
| style="opacity: 0.3" | ||
| :title="t('deck', 'Share')" |
There was a problem hiding this comment.
| :title="t('deck', 'Share')" | |
| v-tooltip="t('deck', 'Share')" |
Signed-off-by: Ishant <ishantgupta777@gmail.com>
Done. Please have a look. |
3 participants
Signed-off-by: Ishant ishantgupta777@gmail.com
Fixed issue and resolves #1679 of the tooltip.