Skip to content

Fix searching for sharees #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 1 commit into from
Apr 21, 2020
Merged

Fix searching for sharees #1726

juliusknorr merged 1 commit into from
Apr 21, 2020

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Apr 20, 2020 •
edited
Loading

  • Add exact matches first
  • Properly fetch sharees on first load
  • debounce search
  • Load all itemTypes

Fixes #1678

@juliusknorr juliusknorr added this to the 🚀 Next major 1.0.0 milestone Apr 20, 2020
This was referenced Apr 20, 2020
Closed
Merged
jakobroehrl
jakobroehrl approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@jakobroehrl jakobroehrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works

@juliusknorr
Fix searching for sharees
871a399 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/sharing-search branch from c7a6c02 to 871a399 Compare April 21, 2020 07:30
@juliusknorr juliusknorr merged commit 04c8bf2 into master Apr 21, 2020
@juliusknorr juliusknorr deleted the bugfix/sharing-search branch April 21, 2020 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakobroehrl jakobroehrl jakobroehrl approved these changes

@ishantgupta777 ishantgupta777 Awaiting requested review from ishantgupta777

Assignees

No one assigned

Labels

4. to release bug

Projects

None yet

Milestone

🚀 Next major 1.0.0

Development

Successfully merging this pull request may close these issues.

v1 beta 1: not all users/groups show up as options to share with

3 participants

@juliusknorr @jakobroehrl