Skip to content

Conversation

@juliusknorr
Copy link
Member

image

Fixes #1673 and parts of #1709

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@jakobroehrl
Copy link
Contributor

@juliushaertl what is the markdown code to generate a checkbox?

@putt1ck
Copy link

putt1ck commented Apr 21, 2020

The use of 2 square brackets with a space between is how the old editor did it (and also I think github MD) [ ]

@jakobroehrl
Copy link
Contributor

The use of 2 square brackets with a space between is how the old editor did it (and also I think github MD) [ ]

Tried it so, doesn't work for me.

@stefan-niedermann
Copy link
Member

- [ ]

try minus space bracket space bracket

@putt1ck
Copy link

putt1ck commented Apr 21, 2020

The use of 2 square brackets with a space between is how the old editor did it (and also I think github MD) [ ]

Tried it so, doesn't work for me.

Testing on v1b1, the card view shows a check list when I add something like

[ ] an item
[ ] another item

(at this point the card shows a ✅ 0/2)

But the view of description continues to show just [ ] an item and the only way to check one is replace the space with an x

@putt1ck
Copy link

putt1ck commented Apr 21, 2020

- [ ]

try minus space bracket space bracket

I tried that, which makes it autolist while editting (useful :) ) but still doesn't render in a way that allows a user to mark the check box by clicking it.

@juliusknorr
Copy link
Member Author

I tried that, which makes it autolist while editting (useful :) ) but still doesn't render in a way that allows a user to mark the check box by clicking it.

This is what this pull request implements for the preview mode. However there is still a small issue, since the library we use for checkmarks in markdown only supports list style checkboxes - [x] not independent ones [x], so we need to adjust the regex for the card badges as I don't see a way to support both right now.

@juliusknorr
Copy link
Member Author

Peek 2020-04-21 08-35

Copy link
Contributor

@jakobroehrl jakobroehrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v1.0.0-beta1 Bug report: No images in Description Box

5 participants