Skip to content

Conversation

@juliusknorr
Copy link
Member

Signed-off-by: Julius Härtl jus@bitgrid.net

  • Resolves: #
  • Target version: master

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@stefan-niedermann
Copy link
Member

Hey @juliushaertl

i guess also 3rd party clients should also check this and hide the comments as well?

But how can one check this? A quick look at the capabilities-endpoint (sample) did not reveal any "comments"-app...?

@juliusknorr
Copy link
Member Author

Maybe @tobiasKaminsky can help here as that should also be done on the files app. Is there something like that already?

@tobiasKaminsky
Copy link
Member

I think comments are a core feature and cannot be disabled, @blizzz

@juliusknorr
Copy link
Member Author

At least occ app:disable comments works

@tobiasKaminsky
Copy link
Member

@stefan-niedermann
Copy link
Member

Thank you @tobiasKaminsky

We will track this in nextcloud/files-clients#108 and stefan-niedermann/nextcloud-deck#401

@blizzz
Copy link
Member

blizzz commented Apr 23, 2020

At least occ app:disable comments works

Technically, it just hides the UI. The functionality itself is still there. The comments service and model are both in the server, and the API is implement in DAV, which you cannot disable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants