Set board title as browser title #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
=======================================
Coverage 76.56% 76.56%
=======================================
Files 33 33
Lines 973 973
=======================================
Hits 745 745
Misses 228 228 |
juliusknorr
force-pushed
the
browser-title
branch
from
910d6c9 to
f3d8bcf
Compare
pixelipo
reviewed
Jun 19, 2017
js/controller/BoardController.js
Outdated
Contributor
There was a problem hiding this comment.
It would look a bit better with a different divider between board title and app title, such as · or |
Member
Author
There was a problem hiding this comment.
Yes, looks better. 👍
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
browser-title
branch
from
f3d8bcf to
6d8dbee
Compare
pixelipo
approved these changes
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #136