Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jun 3, 2020

Let's hope this saves @stefan-niedermann some hassle 😉

We basically used different frontend routes in deck:

Version Board URL Card URL
< 1.0.0 #!/board/:id #!/board/:id/card/:cardId
1.0.0 beta/rc #/boards/:id #/boards/:id/cards/:cardId
>= 1.0.0 #/board/:id #/board/:id/card/:cardId

This PR makes sure that all previously announced route formats keep working by redirecting to the correct one.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@stefan-niedermann
Copy link
Member

Okay, just to make sure: version 1.0.1 (the patch version update after the new major version) did introduce new routes?

stefan-niedermann added a commit to stefan-niedermann/nextcloud-deck that referenced this pull request Jun 3, 2020
@juliusknorr
Copy link
Member Author

OK, sorry about the confusion, I actually mixed up that this routes:
#/boards/:id | #/boards/:id/cards/:cardId
were only part of the beta versions as #1728 was already merged before the final 1.0.0 so I'd the android app should be fine by just handling pre 1.0.0 and 1.0.0 routes as long as you keep supporting 0.8.x

stefan-niedermann added a commit to stefan-niedermann/nextcloud-deck that referenced this pull request Jun 3, 2020
@stefan-niedermann
Copy link
Member

Ah, glad i asked 😄

Fixed in the Android app now 🙂

@juliusknorr juliusknorr merged commit a4532dd into master Jun 3, 2020
@juliusknorr juliusknorr deleted the bugfix/noid/route-redirect branch June 3, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants