Skip to content

Conversation

@Chartman123
Copy link
Contributor

@Chartman123 Chartman123 commented Sep 8, 2020

Add additional ', so that the resulting SQL query is correct

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@Chartman123
Copy link
Contributor Author

I've tested the fix on our Nextcloud and the error messages in the log files have gone.

@juliusknorr
Copy link
Member

Thanks a lot for the fix 👍

Mind to add a signoff message to your commit? :)

@Chartman123
Copy link
Contributor Author

Mind to add a signoff message to your commit? :)

Sorry... Is it possible to change the commit message or how can I add the signoff message?

@juliusknorr
Copy link
Member

You should be able to just signoff the last commit and do a force push with the following commands on your branch:

git commit --amend --signoff
git push -f

@Chartman123
Copy link
Contributor Author

You should be able to just signoff the last commit and do a force push with the following commands on your branch:

git commit --amend --signoff
git push -f

Ok, so I'll have to install git first... I edited the file and created the PR online directly in GitHub

Add additional ', so that the resulting SQL query is correct

Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123
Copy link
Contributor Author

Apparently it worked ;-)

@juliusknorr juliusknorr mentioned this pull request Sep 10, 2020
@juliusknorr juliusknorr merged commit e48ff44 into nextcloud:master Sep 10, 2020
@Chartman123 Chartman123 deleted the patch-1 branch September 10, 2020 07:17
@juliusknorr juliusknorr mentioned this pull request Sep 16, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong SQL Selects resulting from new code

3 participants