cover images #2858

jakobroehrl · 2021-03-05T13:56:27Z

Signed-off-by: Jakob Röhrl jakob.roehrl@web.de

Resolves: Images for Cards #1635
shows the 1st image attachment:

Questions/Todo

change of the board setting "show cover images" is only after page upload applied
new uploaded image attachments are only after page reload shown
show the first two pics? (then I have to shrink the image height to 1/2)

lib/Migration/Version10400Date20210305.php

juliusknorr · 2021-04-16T15:23:24Z

appinfo/info.xml

 - 🚀 Get your project organized

 </description>
-    <version>1.4.0-alpha1</version>


If you need to bump the version for migrations, please only bump the alpha1 to alpha2, the regular version bump will be done during the release process.

juliusknorr · 2021-04-16T15:24:40Z

lib/Controller/BoardController.php

 	 */
-	public function update($id, $title, $color, $archived) {
-		return $this->boardService->update($id, $title, $color, $archived);
+	public function update($id, $title, $color, $archived, $coverImages) {


We would need to support this in the API Controller as well for the mobile app.

juliusknorr · 2021-04-16T15:27:56Z

lib/Db/BoardMapper.php

 	 */
 	public function find($id, $withLabels = false, $withAcl = false) {
-		$sql = 'SELECT id, title, owner, color, archived, deleted_at, last_modified FROM `*PREFIX*deck_boards` ' .
+		$sql = 'SELECT id, title, owner, color, archived, deleted_at, last_modified, cover_images FROM `*PREFIX*deck_boards` ' .


I'm not entirely sure if we should rather make this a user setting. In any case we should reuse the ConfigService for this instead of adding more fields to the board table to keep it flexible.

stefan-niedermann · 2021-04-17T07:26:12Z

We (Android app) are quite confused at the moment. It was really nice if one could describe the target state.

How many images will be shown? 1-3? max. 1? ...?
Is there a max-height for the image?
What about this setting? I guess it's to turn it off / on at all, not to make the shown image configurable per card by the user?
Will or won't this setting be synchronizable? Since @juliushaertl said it should not go into the boards column, we should talk about synchronizable per-board settings in the long term

jakobroehrl · 2021-04-19T08:35:59Z

@stefan-niedermann
I like the new implementation in the Android App. :)
The first 3 pics are shown in the corresponding card and there is a global setting for showing this or not

@juliushaertl: How we will do it in the WebApp? Start like doing it in the Android App?

juliusknorr · 2021-04-19T12:22:48Z

Open questions i would like to clarify before going any further:

Will only pictures be used for this or also previews of for example office files?
In which order will the images be picked? Should there be a manual way to select or will it always be the 3 newest?

How many images will be shown? 1-3? max. 1? ...?

Trello has a dedicated option for making an image a cover for example which I personally would prefer rather than trying to magically find a picture as that could always lead to seeing an image there which you might not want or might not help to get a better idea on what the card is about.

Is there a max-height for the image?

There should be one, yes.

What about this setting? I guess it's to turn it off / on at all, not to make the shown image configurable per card by the user?
Will or won't this setting be synchronizable? Since @juliushaertl said it should not go into the boards column, we should talk about synchronizable per-board settings in the long term

Yes, those settings could still be exposed through the board api endpoints even if they are stored separately. My main concern is that just adding an individual column for each possible setting to the board table doesn't scale very well

stefan-niedermann · 2021-04-19T12:34:38Z

Will only pictures be used for this or also previews of for example office files?

The Android app started with only pictures because otherwise this will cause confusion why attachments which have been uploaded with Deck < 1.3.0 are not shown. We will probably change this behavior when the attachment migration is provided.

In which order will the images be picked? Should there be a manual way to select or will it always be the 3 newest?

In the first draft, the Android app just picks the three first ones in the database. The three most recent sounds better, but i would avoid to make this selectable by the user because this needs a manual user interaction, it will clutter the UI and it will cause maintenance efforts for the options which are probably put into something other more important stuff. But ringing in @nextcloud/designers for this 😉

Yes, those settings could still be exposed through the board api endpoints even if they are stored separately.

Is this really board related? IMHO a global setting for this makes more sense (also a question for @nextcloud/designers)

stefan-niedermann · 2021-04-23T06:06:11Z

Oh, another hint: Think about how cover images work in combination with compact mode.
I put the images on the left side to not increase the height of each item:

jakobroehrl · 2021-10-01T07:59:57Z

@weeman1337
Could you maybe help me on getting this done?

change of the board setting "show cover images" is only after page upload applied
new uploaded image attachments are only after page reload shown
show the first two pics? (then I have to shrink the image height to 1/2)

weeman1337 · 2021-10-04T15:38:23Z

Hi @jakobroehrl . If it is okay for you I would submit some commits.

jakobroehrl · 2021-10-04T18:34:34Z

Hi @jakobroehrl . If it is okay for you I would submit some commits.

This would be awesome, thanks!

jakobroehrl · 2021-10-15T11:03:57Z

Hi @jakobroehrl . If it is okay for you I would submit some commits.

@weeman1337 This would be awesome, thanks!

Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>

frozenbanana · 2022-06-22T11:52:42Z

I have been checking the status on this PR since a while back. Can I help somehow?

xstable · 2022-10-25T09:01:22Z

Is this issue outdated? Would love to see those pretty images at the cardlist.
How can we contribute ?

juliusknorr · 2022-10-27T17:53:48Z

When I talked to @jakobroehrl last time he mentioned that he would appreciate if someone could take over the pull request.

So I think the best would be to checkout the changes and push them to your own fork to open a new pull request then.

Let me know if you have any questions, looking forward to your contribution.

juliusknorr · 2022-12-30T13:39:03Z

Let me close this for now. If anyone wants to pick up the work feel free to open a new pull request with it.

jakobroehrl added enhancement help wanted design 2. developing labels Mar 5, 2021

jakobroehrl added this to the 1.4.0 milestone Mar 5, 2021

jakobroehrl self-assigned this Mar 5, 2021

jakobroehrl requested a review from juliusknorr March 5, 2021 13:57

nickvergessen reviewed Mar 9, 2021

View reviewed changes

lib/Migration/Version10400Date20210305.php Outdated Show resolved Hide resolved

nickvergessen reviewed Mar 9, 2021

View reviewed changes

lib/Migration/Version10400Date20210305.php Outdated Show resolved Hide resolved

jakobroehrl force-pushed the enh/coverPics branch 4 times, most recently from 206bfb6 to b9cc583 Compare March 11, 2021 08:48

juliusknorr modified the milestones: 1.4.0, 1.5.0, 2.0.0 Apr 13, 2021

juliusknorr reviewed Apr 16, 2021

View reviewed changes

stefan-niedermann mentioned this pull request Apr 18, 2021

Cover images stefan-niedermann/nextcloud-deck#941

Merged

stefan-niedermann mentioned this pull request May 31, 2021

Migrate Deck attachments to File attachments #3101

Open

3 tasks

jakobroehrl force-pushed the enh/coverPics branch from b9cc583 to 5832c0c Compare July 9, 2021 11:07

jakobroehrl requested review from juliusknorr and nickvergessen July 9, 2021 13:19

jakobroehrl modified the milestones: 1.5.0, 1.6.0 Jul 9, 2021

nickvergessen removed their request for review July 16, 2021 11:44

nickvergessen mentioned this pull request Jul 16, 2021

Show cover image of deck cards if popssible nextcloud/spreed#6032

Open

juliusknorr mentioned this pull request Oct 19, 2021

Provide proper thumbnail url in search #3383

Open

jakobroehrl added 4 commits December 17, 2021 12:56

cover images

d489855

Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>

show the images

abd0dee

Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>

fix sql

c40f6b2

Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>

styling, some fixes

997c7e3

Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>

jakobroehrl force-pushed the enh/coverPics branch from 456c446 to 997c7e3 Compare December 17, 2021 12:09

juliusknorr modified the milestones: 1.6.0, 1.7.0 Dec 30, 2021

juliusknorr modified the milestones: 1.7.0 (Nextcloud 24), 1.8.0 (Nextcloud 25) Apr 29, 2022

juliusknorr closed this Dec 30, 2022

juliusknorr mentioned this pull request Feb 2, 2023

Images for Cards #1635

Closed

jszeibert mentioned this pull request Jun 5, 2023

Card cover jszeibert/deck#93

Closed

2 tasks

jszeibert mentioned this pull request Aug 18, 2023

Card Cover Images #5035

Merged

5 tasks

cover images #2858

cover images #2858

Uh oh!

Conversation

jakobroehrl commented Mar 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

juliusknorr Apr 16, 2021

Choose a reason for hiding this comment

Uh oh!

juliusknorr Apr 16, 2021

Choose a reason for hiding this comment

Uh oh!

juliusknorr Apr 16, 2021

Choose a reason for hiding this comment

Uh oh!

stefan-niedermann commented Apr 17, 2021

Uh oh!

jakobroehrl commented Apr 19, 2021

Uh oh!

juliusknorr commented Apr 19, 2021

Uh oh!

stefan-niedermann commented Apr 19, 2021

Uh oh!

stefan-niedermann commented Apr 23, 2021

Uh oh!

jakobroehrl commented Oct 1, 2021

Uh oh!

weeman1337 commented Oct 4, 2021

Uh oh!

jakobroehrl commented Oct 4, 2021

Uh oh!

jakobroehrl commented Oct 15, 2021

Uh oh!

frozenbanana commented Jun 22, 2022

Uh oh!

xstable commented Oct 25, 2022

Uh oh!

juliusknorr commented Oct 27, 2022

Uh oh!

juliusknorr commented Dec 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jakobroehrl commented Mar 5, 2021 •

edited

Loading