Skip to content

Remove unused argument from transfer ownership #3712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 1 commit into from
Apr 11, 2022
Merged

Remove unused argument from transfer ownership #3712

juliusknorr merged 1 commit into from
Apr 11, 2022

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Apr 11, 2022

The owner is not used in the controller arguments

deck/lib/Controller/BoardController.php

Line 165 in 23f0b16

public function transferOwner(int $boardId, string $newOwner): DataResponse {
as it is inherited from the board that is being transferred.

@juliusknorr
Remove unused argument
487073c 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

juliusknorr commented Apr 11, 2022

No backports needed, cherry-picked directly into #3665 and #3664

@juliusknorr juliusknorr merged commit 669eec1 into master Apr 11, 2022
@delete-merged-branch delete-merged-branch bot deleted the cleanup/transfer-store branch April 11, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luka-nextcloud luka-nextcloud luka-nextcloud approved these changes

Assignees

No one assigned

Labels

3. to review bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr @luka-nextcloud