feat: add validators to check values in services #4059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luka-nextcloud
requested review from
julien-nc,
max-nextcloud,
nickvergessen and
vinicius73
Member
|
Any breaking changes in here? I didn't see one at the first look, but just to make sure 😉 |
juliusknorr
reviewed
Sep 22, 2022
Member
|
@luka-nextcloud Indentation seems off quite a bit in some places. Maybe double check your editor settings to use tab indentation. php-cs-fixer should however be able to auto fix those with |
luka-nextcloud
force-pushed
the
feature/improve-security-level
branch
from
a9ef6d6 to
c6c47e5
Compare
Contributor
Author
|
@juliushaertl Please check again. |
luka-nextcloud
force-pushed
the
feature/improve-security-level
branch
2 times, most recently
from
64ccef1 to
4228cc0
Compare
juliusknorr
reviewed
Oct 17, 2022
juliusknorr
reviewed
Oct 17, 2022
luka-nextcloud
force-pushed
the
feature/improve-security-level
branch
2 times, most recently
from
9e130d7 to
4c57b5a
Compare
Signed-off-by: Luka Trovic <luka@nextcloud.com>
juliusknorr
force-pushed
the
feature/improve-security-level
branch
from
4c57b5a to
1217b37
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
approved these changes
Oct 31, 2022
Member
|
/backport to stable25 |
Member
|
/backport to stable24 |
Member
|
/backport to stable23 |
|
The backport to stable24 failed. Please do this backport manually. |
|
The backport to stable23 failed. Please do this backport manually. |
This was referenced Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luka Trovic luka@nextcloud.com
Summary
TODO
Checklist