-
Notifications
You must be signed in to change notification settings - Fork 310
Added ability to mark a card as done #4131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Closes #534 Signed-off-by: Thanos Kamber <thanos.kamber@gmail.com>
Signed-off-by: Thanos Kamber <thanos.kamber@gmail.com>
Signed-off-by: Thanos Kamber <thanos.kamber@gmail.com>
Signed-off-by: Thanos Kamber <thanos.kamber@gmail.com>
|
Wow, nice great to see this as a contribution coming. While I haven't looked in detail at the code yet, could you base your changes on the master branch? New features only get merged to master for the next release. |
|
Nice contribution 🙂 🚀 Please also keep in mind the Rest API:
|
Uh sorry will do, should I close this pr? |
Thanks! :D
|
Feel free to either close and open a new pull request or rebase the branch and change the base branch. |
|
Cool I'm just gonna close this and open a new one for master then. Edit: The new pr #4137 |
Summary
This adds the ability to mark a card as done.
When the card is marked as done if it has a due date then it makes it un-editable, if it doesn't it simply displays "No due date"
Marking a card as done also hides it from the upcoming section.
TODO
Checklist