Skip to content

Conversation

@juliusknorr
Copy link
Member

Replaces #3279

Fixes #2927

@juliusknorr
Copy link
Member Author

Behat failures are unrelated, fix is in #4184

… job

Limit deleted cards in one cron job run to 500

Converted spaces to tabs

Added missing import for CardMapper class

Added another missing import for CardMapper class

Fixed response object in findToDelete method + fixed 2 misspellings in API.md

Fixed invalid parameter type

Fix DeleteCronTest

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Fix lint errors

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Copy link
Member

@marcelklehr marcelklehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@juliusknorr juliusknorr merged commit 95837d0 into master Nov 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the 3on108/master branch November 7, 2022 17:26
@Stachelritter
Copy link

Would it be possible to do a backport and release on stable25, or will this fix only be available with version 26 of Nextcloud? @juliushaertl

@juliusknorr
Copy link
Member Author

Yes, lets backport that 👍

@juliusknorr
Copy link
Member Author

/backport to stable25

@juliusknorr
Copy link
Member Author

/backport to stable24

@31337-4554551n
Copy link

I believe this would be the right place to mention this, but I'm seeing everything related to deck cards auto deleting when deleted being marked as merged/closed/complete, but the issue persists.

Deleted deck cards still remain forever. NC 25.
-can't seem to attach screenshot, but items are still in deleted items forever-newly created/deleted ones also don't autodelete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deleted deck cards are being kept in deleted items forever

6 participants