Skip to content

feat(Description): Use text as editor if available #4399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 3 commits into from
Feb 3, 2023
Merged

feat(Description): Use text as editor if available #4399

juliusknorr merged 3 commits into from
Feb 3, 2023

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jan 27, 2023 •
edited
Loading

Resolves #1561

Summary

Screenshot 2023-02-02 at 07 57 31

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@juliusknorr juliusknorr mentioned this pull request Jan 30, 2023
Merged
21 tasks
@juliusknorr juliusknorr marked this pull request as ready for review February 2, 2023 06:56
marcelklehr
marcelklehr approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@marcelklehr marcelklehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Didn't test.

@juliusknorr
feat(Description): Use text as editor if available
c9f539b 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: Insert attachments and menubar stickyness
1ad6375 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
tests(cypress): Basic editor tests
1e9060b 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr merged commit 2f58f9c into main Feb 3, 2023
@delete-merged-branch delete-merged-branch bot deleted the enh/text-editor branch February 3, 2023 18:15
@reox reox mentioned this pull request Feb 5, 2023
Closed
@nico-arnold
Copy link

nico-arnold commented Jan 17, 2024

Nice to see that! Where can I change the editor? I sadly didn't find any point to change the editor to NC Text. From the "merged" tag here, I guess it's already implemented in Nextcloud Hub 7 (28.0.1)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud luka-nextcloud is a code owner

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees

No one assigned

Labels

3. to review enhancement

Projects

📝 Office team
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Integrate Nextcloud Text as a markdown editor

4 participants

@juliusknorr @nico-arnold @marcelklehr