Skip to content

ci: Add query count for integration tests #4454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
juliusknorr wants to merge 1 commit into from
Closed

ci: Add query count for integration tests #4454

juliusknorr wants to merge 1 commit into from

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Feb 16, 2023

Signed-off-by: Julius Härtl jus@bitgrid.net

  • Resolves: #
  • Target version: main

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2023

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 61324 was 0 (+100%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@juliusknorr
ci: Add query count for integration tests
011488d 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

juliusknorr commented Feb 17, 2023

Added to #4452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud luka-nextcloud will be requested when the pull request is marked ready for review luka-nextcloud is a code owner

@grnd-alt grnd-alt Awaiting requested review from grnd-alt grnd-alt will be requested when the pull request is marked ready for review grnd-alt is a code owner

@elzody elzody Awaiting requested review from elzody elzody will be requested when the pull request is marked ready for review elzody is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@juliusknorr