Skip to content

Ensure $boardId is an integer #4765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 1 commit into from
Jun 9, 2023
Merged

Ensure $boardId is an integer #4765

juliusknorr merged 1 commit into from
Jun 9, 2023

Conversation

@solracsf
Copy link
Member

@solracsf solracsf commented Jun 6, 2023

  • Target version: main

Fix: Exception: OCA\Deck\Service\BoardService::find(): Argument #1 ($boardId) must be of type int, string given

Summary

Somehow, PGsql returns an int but MySQL returns a string
This ensure correct datatype.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@solracsf solracsf requested a review from juliusknorr June 6, 2023 09:05
@cypress
Copy link

cypress bot commented Jun 6, 2023 •
edited
Loading

Passing run #963 ↗︎

0 15 0 0 Flakiness 0

Details:

Merge b53d6a3 into afcccab...
Project: Deck Commit: ec7ec01dd9 ℹ️
Status: Passed Duration: 02:15 💡
Started: Jun 9, 2023 7:32 AM Ended: Jun 9, 2023 7:35 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@solracsf
Copy link
Member Author

solracsf commented Jun 6, 2023

/backport to stable27

@solracsf
Copy link
Member Author

solracsf commented Jun 6, 2023

/backport to stable26

@solracsf
Copy link
Member Author

solracsf commented Jun 6, 2023

/backport to stable25

@solracsf solracsf changed the title Ensure boardId is an integer Ensure $boardId is an integer Jun 6, 2023
@solracsf @juliusknorr
Ensure boardId is an integer
b53d6a3 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@juliusknorr juliusknorr merged commit 186082c into main Jun 9, 2023
@juliusknorr juliusknorr deleted the boardIdInt branch June 9, 2023 07:42
This was referenced Jun 9, 2023
Merged
Merged
@juliusknorr juliusknorr mentioned this pull request Jun 9, 2023
Merged
4 tasks
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 9, 2023
Merged
@solracsf solracsf mentioned this pull request Jun 9, 2023
Closed
@joshtrichards joshtrichards mentioned this pull request Oct 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@solracsf @juliusknorr