Bugfix/980/fts argument type #983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/980/fts-argument-type
branch
from
ae1bcd9 to
6af28f1
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Member
Author
|
@daita I've added some exception catching but I will still keep the app enabled check to make sure we don't register anything at all. |
Member
|
I think that once nextcloud/server#15035 is merged, it would be enough to just check for IFullTextSearchManager->isAvailable() within the registerFullTextSearch might be overkill, but more exception is still good :) |
Member
Author
|
Ok, we can adjust that afterwards. I'll merge this for now so I can push out anther beta. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #980
@daita In case the fulltextsearch app is not enabled i get the following error. For now i worked around by checking the enabled state manually with a68c1e9 but I think it shouldn't fail hard if the app is not enabled: