Disable rewriteip for apache image #1010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
force-pushed
the
feature/disable-remoteip2
branch
from
c9d691a to
4245e23
Compare
Contributor
|
There is another PR solving a similar issue: #1048 |
Contributor
Author
I would like to disable mod rewriteip and not use the overwrite* variables. Without mod rewrite most setups behind nginx and traefik should work by setting trusted proxies out of the box. The other PR is not ready from my pov. If you defined OVERWRITEWEBROOT (or any other variable) once it's not possible to unset it again due the config merge Nextcloud usually does. Using the proper default variable (or null) is required to workaround that limitation. |
J0WI
approved these changes
Mar 31, 2020
Contributor
|
@kesselb this needs rebase |
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
feature/disable-remoteip2
branch
from
9cb1895 to
8f268a8
Compare
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
feature/disable-remoteip2
branch
from
e2515a5 to
97d20ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the ip address visible to Nextcloud is
X-Real-IPif the request is coming from10.0.0.0/8,172.16.0.0/12or192.168.0.0/16.That's a problem because Nextcloud will ignore
HTTP_X_FORWARDED_HOST/HTTP_X_FORWARDED_PROTOand people see invalid (absolute) urls.