Add NEXTCLOUD_DEFAULT_PHONE_REGION to configuration variables#1795
Add NEXTCLOUD_DEFAULT_PHONE_REGION to configuration variables#1795LeoColman wants to merge 1 commit intonextcloud:masterfrom LeoColman:master
Conversation
|
Hey guys! |
|
I'm just afraid of adding a new ENV for every setting that was ever implemented by Nextcloud. You can already use environment variables with the |
|
I was thinking of this one just because nextcloud has warnings on the phone number setting specifically. |
|
I don't know why Nextcloud warns about this optional value. This would be |
|
So by just adding the environment variable *NC_DEFAULT_PHONE_REGION*
and it will work?
Is this documented anywhere?
Aug. 18, 2022 15:34:23 J0WI ***@***.***>:
… I don't know why Nextcloud warns about this optional value.
This would be *NC_default_phone_region* or *NC_DEFAULT_PHONE_REGION*.
—
Reply to this email directly, view it on GitHub[#1795 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAMBCI5MEVT32W5G2QU5QGTVZZ623ANCNFSM54W2X3CA].
You are receiving this because you authored the thread.[Tracking image][https://github.com/notifications/beacon/AAMBCI5LTHU2GL7MWTKA3DTVZZ623A5CNFSM54W2X3CKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJC2M4XY.gif]
|
|
The only 'documentation' is here: https://github.com/nextcloud/server/blob/fd645d48028335f65c567e708b80942f995f78d9/lib/private/Config.php#L86-L108 But it's used in CI and Debugging like here: https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/occ_command.html?highlight=nc_#debugging |
|
Maybe we can extract the documentation to somewhere more user friendly. Do you think a section in the readme of this repository makes sense? I'd be happy to write it |
|
Although it's more related to nextcloud itself, I think the docker users would benefit a lot by knowing this variable configuration |
|
Yes, I'd even prefer a hint in the official docs because this is not limited to the Docker image. |
|
Alright! |
Closes #1544
Closes #1465
Signed-off-by: Leonardo Colman Lopes dev@leonardo.colman.com.br