Skip to content

Add NEXTCLOUD_DEFAULT_PHONE_REGION to configuration variables#1795

Closed
LeoColman wants to merge 1 commit intonextcloud:masterfrom
LeoColman:master
Closed

Add NEXTCLOUD_DEFAULT_PHONE_REGION to configuration variables#1795
LeoColman wants to merge 1 commit intonextcloud:masterfrom
LeoColman:master

Conversation

@LeoColman
Copy link

Closes #1544
Closes #1465

Signed-off-by: Leonardo Colman Lopes dev@leonardo.colman.com.br

Closes #1544
Closes #1465

Signed-off-by: Leonardo Colman Lopes <dev@leonardo.colman.com.br>
@LeoColman
Copy link
Author

Hey guys!
Is anything missing in this PR? Can we get it merged?
@J0WI

@J0WI
Copy link
Contributor

J0WI commented Aug 17, 2022

I'm just afraid of adding a new ENV for every setting that was ever implemented by Nextcloud. You can already use environment variables with the NC_ prefix for simple settings.

@LeoColman
Copy link
Author

I was thinking of this one just because nextcloud has warnings on the phone number setting specifically.
Having to connect to the instance every time to set the phone setting is weird. Do you think there's an alternative for this setting in the docker nextcloud version?

@J0WI
Copy link
Contributor

J0WI commented Aug 18, 2022

I don't know why Nextcloud warns about this optional value.

This would be NC_default_phone_region or NC_DEFAULT_PHONE_REGION.

@LeoColman
Copy link
Author

LeoColman commented Aug 18, 2022 via email

@J0WI
Copy link
Contributor

J0WI commented Aug 22, 2022

@LeoColman
Copy link
Author

Maybe we can extract the documentation to somewhere more user friendly.

Do you think a section in the readme of this repository makes sense?

I'd be happy to write it

@LeoColman
Copy link
Author

Although it's more related to nextcloud itself, I think the docker users would benefit a lot by knowing this variable configuration

@J0WI
Copy link
Contributor

J0WI commented Aug 23, 2022

Yes, I'd even prefer a hint in the official docs because this is not limited to the Docker image.

@LeoColman
Copy link
Author

Alright!
I've opened a pull request in the documentation repository
nextcloud/documentation#9143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning about default_phone_region Warning no default phone region set

2 participants