Fix for PR #2095 breaking post-installation scripts in k8s#2115
Merged
J0WI merged 4 commits intonextcloud:masterfrom Jan 9, 2024
Sad-Soul-Eater:Sad-Soul-Eater-patch-1
Merged
Fix for PR #2095 breaking post-installation scripts in k8s#2115J0WI merged 4 commits intonextcloud:masterfrom Sad-Soul-Eater:Sad-Soul-Eater-patch-1
J0WI merged 4 commits intonextcloud:masterfrom
Sad-Soul-Eater:Sad-Soul-Eater-patch-1
Conversation
Signed-off-by: Yevhen Kolomeiko <Jarvis2709@gmail.com>
joshtrichards
approved these changes
Dec 5, 2023
Member
joshtrichards
left a comment
joshtrichards
left a comment
There was a problem hiding this comment.
Unable to test, but simple change that makes sense and syntax is valid.
Member
|
@dvaerum Feel like weighing in? |
joshtrichards
changed the title
Contributor
Yes, merge 😉 From what I have done of quick testing, it works. But, I am curious because I cannot see how this problem should be k8s released 🤔 |
Contributor
Author
In k8s |
Contributor
|
Thanks for the info @Sad-Soul-Eater that is good to know |
J0WI
requested changes
Dec 12, 2023
Signed-off-by: Yevhen Kolomeiko <Jarvis2709@gmail.com>
Contributor
|
just closed #2125 as this would resolve some issues we're having in the nextcloud/helm repo. Thank you @Sad-Soul-Eater ! @J0WI can this be merged now? |
This was referenced Dec 15, 2023
J0WI
reviewed
Dec 20, 2023
Signed-off-by: Yevhen Kolomeiko <Jarvis2709@gmail.com>
Signed-off-by: Yevhen Kolomeiko <Jarvis2709@gmail.com>
J0WI
approved these changes
Dec 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2114