[admin] Nginx: Change mimetype for javascript #10375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Sorry, but I am not qualified to review this 🤷 |
| include mime.types; | ||
| types { | ||
| application/javascript js mjs; | ||
| text/javascript js mjs; |
Member
There was a problem hiding this comment.
this seems to be the actual change? 👍
Contributor
Author
There was a problem hiding this comment.
Yes but we need the other one as well to gzip compress it.
susnux
force-pushed
the
fix/admin-nginx-js-mime
branch
from
b19529b to
e329828
Compare
…text/javascript` * See also https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types#textjavascript Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/admin-nginx-js-mime
branch
from
e329828 to
1ef2afc
Compare
ChristophWurst
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change mimetype from
application/javascripttotext/javascriptSee also https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types#textjavascript
☑️ Resolves