Skip to content

Conversation

@BernieO
Copy link
Contributor

@BernieO BernieO commented Sep 22, 2019

Signed-off-by: Bernhard Ostertag bernieo.github@gmx.de

Nextcloud 17 adds the Same-Origin header which was removed with Nextcloud 12.
ref #1597 (which should IMHO be merged before release of Nextcloud 17)

Signed-off-by: Bernhard Ostertag <bernieo.github@gmx.de>

Nextcloud 17 adds the Same-Origin header which was removed with Nextcloud 12.
ref #1597 (which should IMHO be merged before release of Nextcloud 17)
Copy link
Contributor

@J0WI J0WI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also document the new always attribute for security headers?

@J0WI J0WI added this to the Nextcloud 17 milestone Oct 3, 2019
@J0WI
Copy link
Contributor

J0WI commented Oct 3, 2019

🏓 @nickvergessen this should be mentioned in the release notes

@skjnldsv skjnldsv requested a review from rullzer October 29, 2019 14:20
@J0WI
Copy link
Contributor

J0WI commented Nov 20, 2019

@BernieO could you sign-off your commits?

@nickvergessen
Copy link
Member

Also the try_files changes are missing from there

@BernieO
Copy link
Contributor Author

BernieO commented Nov 20, 2019

could you sign-off your commits?

@J0WI I thought I did sign-off the commit.
Is signing-off more than putting Signed-off-by: NAME <MAIL@EXAMPLE.COM> in the commit message?

I am sorry, if I did something wrong. I would also be happy to create a new pull request signed-off (once I know how to do that).

@kesselb kesselb modified the milestones: Nextcloud 17, Nextcloud 18 Nov 20, 2019
@kesselb kesselb merged commit fdd3603 into nextcloud:master Nov 20, 2019
@kesselb
Copy link
Contributor

kesselb commented Nov 20, 2019

Thanks 👍

@J0WI
Copy link
Contributor

J0WI commented Nov 20, 2019

/backport to stable17

@backportbot-nextcloud
Copy link

backport to stable17 in #1713

@jknockaert
Copy link
Contributor

I think the documentation should be updated as well. In fact it tells users to do the exact opposite of what it should be: https://docs.nextcloud.com/server/17/admin_manual/release_notes.html

@jknockaert
Copy link
Contributor

Sorry, I was confused. The PR is doing exactly what I was suggesting here. Forget about my remark.
Thanks for fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants