-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Adapt Updates to nginx configuration #1630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Bernhard Ostertag <bernieo.github@gmx.de> Nextcloud 17 adds the Same-Origin header which was removed with Nextcloud 12. ref #1597 (which should IMHO be merged before release of Nextcloud 17)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also document the new always attribute for security headers?
|
🏓 @nickvergessen this should be mentioned in the release notes |
|
@BernieO could you sign-off your commits? |
|
Also the try_files changes are missing from there |
@J0WI I thought I did sign-off the commit. I am sorry, if I did something wrong. I would also be happy to create a new pull request signed-off (once I know how to do that). |
|
Thanks 👍 |
|
/backport to stable17 |
|
backport to stable17 in #1713 |
|
I think the documentation should be updated as well. In fact it tells users to do the exact opposite of what it should be: https://docs.nextcloud.com/server/17/admin_manual/release_notes.html |
|
Sorry, I was confused. The PR is doing exactly what I was suggesting here. Forget about my remark. |
Signed-off-by: Bernhard Ostertag bernieo.github@gmx.de
Nextcloud 17 adds the Same-Origin header which was removed with Nextcloud 12.
ref #1597 (which should IMHO be merged before release of Nextcloud 17)