Skip to content

OCS API also takes the Accept header into account #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Jan 29, 2018
Merged

OCS API also takes the Accept header into account #659

MorrisJobke merged 1 commit into from
Jan 29, 2018

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Jan 29, 2018

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer
OCS API also takes the Accept header into account
8434417 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added this to the Nextcloud 14 milestone Jan 29, 2018
@rullzer rullzer mentioned this pull request Jan 29, 2018
Merged
6 tasks
@MorrisJobke MorrisJobke merged commit 8d295b3 into master Jan 29, 2018
@MorrisJobke MorrisJobke deleted the ocs_takes_accept branch January 29, 2018 14:01
@MorrisJobke
Copy link
Member

MorrisJobke commented Jan 29, 2018

stable12 35b1abd
stable11 4e3ecdd

@Dagefoerde
Copy link
Member

Dagefoerde commented Jan 29, 2018

I'd like to propose adding that ?format= has priority over the Accept header (and that's a really good thing if you can't manipulate the headers :) ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer @MorrisJobke @Dagefoerde