feat: allow to create keys for shares with anonymous users #1315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
susnux
commented
Dec 18, 2025
susnux
commented
- for feat: allow to create end-to-end encrypted external shares #1276
- for https://github.com/nextcloud-gmbh/customer-feature-requests/issues/1250
- see also feat: allow to share with anonymous users end_to_end_encryption_rfc#71
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
3. to review
artonge
reviewed
Dec 19, 2025
Collaborator
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Wil the key be deleted by the frontend, or shall we add a listener to react to share events?
| * @inheritDoc | ||
| */ | ||
| public function getPrivateKey(string $uid): string { | ||
| public function getPrivateKey(string $uid, ?string $shareToken = null): string { |
Collaborator
There was a problem hiding this comment.
Do we use that method with the shareToken?
I am not 100% sure whether the if properly handles access control.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.