External sites are missing for non-admin users

[phignx]

Steps to reproduce

1. External sites have been added with an admin account
2. Sites are configured for all languages
3. Access rights are not restricted by groups
4. All urls are in https

Expected behaviour

Sites should be present in the header of the web page with the other application icons for all users

Actual behaviour

Sites are missing from the header of the webpage unless the user is part of the Nextcloud admin group

Server configuration

Operating system:
Linux 4.19.0-6-amd64 #1 SMP Debian 4.19.67-2+deb10u2 (2019-11-11) x86_64 GNU/Linux
Web server:
Apache2 2.4.38-3+deb10u3
Database:
mariadb-server 10.3.18-0+deb10u1
PHP version:
PHP 7.3.11-1~deb10u1
Nextcloud version: (see Nextcloud admin page)
Nextcloud 16.0.5
Where did you install Nextcloud from:

List of activated apps:

Enabled:
  - accessibility: 1.2.0
  - activity: 2.9.1
  - admin_audit: 1.6.0
  - apporder: 0.8.0
  - bookmarks: 2.3.1
  - bruteforcesettings: 1.4.0
  - calendar: 1.7.1
  - circles: 0.17.10
  - cloud_federation_api: 0.2.0
  - comments: 1.6.0
  - dav: 1.9.2
  - deck: 0.6.6
  - drawio: 0.9.4
  - external: 3.3.1
  - federatedfilesharing: 1.6.0
  - federation: 1.6.0
  - files: 1.11.0
  - files_external: 1.7.0
  - files_mindmap: 0.0.15
  - files_pdfviewer: 1.5.0
  - files_rightclick: 0.15.1
  - files_sharing: 1.8.0
  - files_texteditor: 2.8.0
  - files_trashbin: 1.6.0
  - files_versions: 1.9.0
  - files_videoplayer: 1.5.0
  - firstrunwizard: 2.5.0
  - gallery: 18.3.0
  - logreader: 2.1.0
  - lookup_server_connector: 1.4.0
  - news: 14.0.1
  - nextcloud_announcements: 1.5.0
  - notes: 3.0.3
  - notifications: 2.4.1
  - oauth2: 1.4.2
  - ocsms: 2.1.6
  - onlyoffice: 3.0.2
  - password_policy: 1.6.0
  - passwords: 2019.11.1
  - polls: 0.10.4
  - privacy: 1.0.0
  - provisioning_api: 1.6.0
  - quicknotes: 0.2.1
  - rainloop: 6.0.4
  - recommendations: 0.4.0
  - serverinfo: 1.6.0
  - sharebymail: 1.6.0
  - spreed: 6.0.4
  - support: 1.0.0
  - survey_client: 1.4.0
  - systemtags: 1.6.0
  - tasks: 0.11.3
  - text: 1.0.2
  - theming: 1.7.0
  - twofactor_backupcodes: 1.5.0
  - updatenotification: 1.6.0
  - user_ldap: 1.6.0
  - user_usage_report: 1.1.2
  - viewer: 1.1.0
  - workflowengine: 1.6.0
Disabled:
  - contacts
  - encryption
  - keeweb
  - mail
  - ojsxc
  - ransomware_detection
  - user_external
  - user_saml

Nextcloud configuration:

<?php
$CONFIG = array (
  'instanceid' => 'ocqzzpknorfi',
  'passwordsalt' => '***REMOVED SENSITIVE VALUE***',
  'secret' => '***REMOVED SENSITIVE VALUE***',
  'trusted_domains' => 
  array (
    0 => 's***REMOVED SENSITIVE VALUE***',
    1 => '***REMOVED SENSITIVE VALUE***',
    2 => '***REMOVED SENSITIVE VALUE***',
  ),
  'datadirectory' => '/var/www/nextcloud/data',
  'overwrite.cli.url' => 'https://***REMOVED SENSITIVE VALUE***',
  'htaccess.RewriteBase' => '/',
  'dbtype' => 'mysql',
  'version' => '16.0.5.1',
  'dbname' => 'nextcloud',
  'dbhost' => 'localhost',
  'dbport' => '',
  'dbtableprefix' => 'oc_',
  'dbuser' => 'nextcloud',
  'dbpassword' => '***REMOVED SENSITIVE VALUE***',
  'installed' => true,
  'ldapIgnoreNamingRules' => false,
  'ldapProviderFactory' => '\\OCA\\User_LDAP\\LDAPProviderFactory',
  'onlyoffice' => 
  array (
    'verify_peer_off' => true,
  ),
  'mail_smtpmode' => 'smtp',
  'mail_smtpauthtype' => 'LOGIN',
  'default_language' => 'fr',
  'memcache.local' => '\\OC\\Memcache\\APCu',
  'redis' => 
  array (
    'host' => '/var/run/redis/redis-server.sock',
    'port' => 0,
    'timeout' => 0.0,
  ),
  'loglevel' => '1',
  'maintenance' => false,
  'theme' => '',
  'mail_smtpsecure' => 'tls',
  'mail_from_address' => '***REMOVED SENSITIVE VALUE***',
  'mail_domain' => '***REMOVED SENSITIVE VALUE***',
  'mail_smtpauth' => 1,
  'mail_smtphost' => '***REMOVED SENSITIVE VALUE***',
  'mail_smtpport' => '587',
  'mail_smtpname' => '***REMOVED SENSITIVE VALUE***',
  'mail_smtppassword' => '***REMOVED SENSITIVE VALUE***',
  'skeletondirectory' => '',
  'app_install_overwrite' => 
  array (
    0 => 'external',
    1 => 'mindmaps',
  ),
  'mail_sendmailmode' => 'smtp',
  'overwriteprotocol' => 'https',
  'updater.release.channel' => 'stable',
  'mysql.utf8mb4' => true,
);

Client configuration

Browser:
Firefox 68.2.0esr (64bits)
Operating system:
Linux 4.19.0-0.bpo.6-amd64 #1 SMP Debian 4.19.67-2+deb10u1~bpo9+1 (2019-09-30) x86_64 GNU/Linux

Logs

Nextcloud log (data/owncloud.log)

{"app":"no app in context","method":"GET","url":"\/ocs\/v2.php\/apps\/notifications\/api\/v2\/notifications","message":{"Exception":"Symfony\\Component\\Routing\\Exception\\RouteNotFoundException","Message":"Unable to generate a URL for the named route \"ocs.provisioning_api.AppsController.disable\" as such route does not exist.","Code":0,"Trace":[{"file":"\/var\/www\/nextcloud\/lib\/private\/Route\/Router.php","line":337,"function":"generate","class":"Symfony\\Component\\Routing\\Generator\\UrlGenerator","type":"->","args":["ocs.provisioning_api.AppsController.disable",{"app":"nextcloud_announcements"},1]},{"file":"\/var\/www\/nextcloud\/lib\/private\/Route\/CachingRouter.php","line":60,"function":"generate","class":"OC\\Route\\Router","type":"->","args":["ocs.provisioning_api.AppsController.disable",{"app":"nextcloud_announcements"},false]},{"file":"\/var\/www\/nextcloud\/lib\/private\/URLGenerator.php","line":95,"function":"generate","class":"OC\\Route\\CachingRouter","type":"->","args":["ocs.provisioning_api.AppsController.disable",{"app":"nextcloud_announcements"},false]},{"file":"\/var\/www\/nextcloud\/apps\/nextcloud_announcements\/lib\/Notification\/Notifier.php","line":89,"function":"linkToOCSRouteAbsolute","class":"OC\\URLGenerator","type":"->","args":["provisioning_api.AppsController.disable",{"app":"nextcloud_announcements"}]},{"file":"\/var\/www\/nextcloud\/lib\/private\/Notification\/Manager.php","line":226,"function":"prepare","class":"OCA\\NextcloudAnnouncements\\Notification\\Notifier","type":"->","args":[{"__class__":"OC\\Notification\\Notification"},"fr"]},{"file":"\/var\/www\/nextcloud\/apps\/notifications\/lib\/Controller\/EndpointController.php","line":92,"function":"prepare","class":"OC\\Notification\\Manager","type":"->","args":[{"__class__":"OC\\Notification\\Notification"},"fr"]},{"file":"\/var\/www\/nextcloud\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":166,"function":"listNotifications","class":"OCA\\Notifications\\Controller\\EndpointController","type":"->","args":["v2"]},{"file":"\/var\/www\/nextcloud\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":99,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Notifications\\Controller\\EndpointController"},"listNotifications"]},{"file":"\/var\/www\/nextcloud\/lib\/private\/AppFramework\/App.php","line":126,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Notifications\\Controller\\EndpointController"},"listNotifications"]},{"file":"\/var\/www\/nextcloud\/lib\/private\/AppFramework\/Routing\/RouteActionHandler.php","line":47,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Notifications\\Controller\\EndpointController","listNotifications",{"__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"},{"apiVersion":"v2","_route":"ocs.notifications.Endpoint.listNotifications"}]},{"function":"__invoke","class":"OC\\AppFramework\\Routing\\RouteActionHandler","type":"->","args":[{"apiVersion":"v2","_route":"ocs.notifications.Endpoint.listNotifications"}]},{"file":"\/var\/www\/nextcloud\/lib\/private\/Route\/Router.php","line":297,"function":"call_user_func","args":[{"__class__":"OC\\AppFramework\\Routing\\RouteActionHandler"},{"apiVersion":"v2","_route":"ocs.notifications.Endpoint.listNotifications"}]},{"file":"\/var\/www\/nextcloud\/ocs\/v1.php","line":82,"function":"match","class":"OC\\Route\\Router","type":"->","args":["\/ocsapp\/apps\/notifications\/api\/v2\/notifications"]},{"file":"\/var\/www\/nextcloud\/ocs\/v2.php","line":24,"args":["\/var\/www\/nextcloud\/ocs\/v1.php"],"function":"require_once"}],"File":"\/var\/www\/nextcloud\/3rdparty\/symfony\/routing\/Generator\/UrlGenerator.php","Line":130,"CustomMessage":"--"},"userAgent":"Mozilla\/5.0 (X11; Linux x86_64; rv:68.0) Gecko\/20100101 Firefox\/68.0","version":"16.0.5.1"}

Browser log

Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log
c) ...

[nickvergessen]

Works fine here. Can you run the following command and send it to me via email <my github name>@nextcloud.com

occ config:list external --private

[phignx]

root@srv-app06:~# sudo -u www-data php /var/www/nextcloud/occ config:list external --private
{
"apps": {
"external": {
"enabled": "yes",
"installed_version": "3.3.1",
"max_site": "7",
"sites": "{"4":{"icon":"811211236_b.jpg","lang":"","type":"link","device":"","groups":["Domain Users","admin"],"redirect":false,"id":4,"name":"Intranoo","url":"https:\/\/REMOVED SENSITIVE VALUE"},"5":{"icon":"office365.png","lang":"fr","type":"link","device":"","groups":["Domain Users","admin"],"redirect":true,"id":5,"name":"Office 365","url":"https:\/\/outlook.office365.com"},"7":{"id":7,"name":"ERP","url":"https:\/\/REMOVED SENSITIVE VALUE\/","lang":"","type":"link","device":"browser","icon":"erp-icon.svg","groups":["admin","Domain Users"],"redirect":true}}",
"types": ""
}
}
}

[nickvergessen]

You limited all your pages to users of the group admin and Domain Users
Is that correct?

[phignx]

I do not think so, how can I check it?

[nickvergessen]

"groups":["Domain Users","admin"]

it definatly is like that.

You can check this in the UI by navigating to the admin settings and then open the … menu and check the group settings:

[phignx]

The field "Groups" is missing :

[nickvergessen]

What does the error say?

[phignx]

I do not know why the "Groups" field is missing but the cause of the error is related to a modification of the ldap request.
The group "Domain users" was outside the root of the group tree specified in the ldap request.
After correcting the request, the external sites are again present for the users but the "Groups" field is still missing.

[nickvergessen]

Ah okay, so the error is because a group was there but is not anymore.

if you send my the uncensored value from the database to my email address, I will fix it for you.

<my github name>@nextcloud.com

occ config:list external --private

[phignx]

There is no problem accessing external sites since I fixed the ldap request.
Only the "groups" field in the configuration parameters of external sites remains missing