Skip to content

Fix language selector entries #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Feb 8, 2018
Merged

Fix language selector entries #78

MorrisJobke merged 1 commit into from
Feb 8, 2018

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Feb 7, 2018

Related to nextcloud/server#8218

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer
Fix language selector entries
559fb0b 
Related to nextcloud/server#8218

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added this to the Nextcloud 14 milestone Feb 7, 2018
@nickvergessen
Copy link
Member

nickvergessen commented Feb 7, 2018

is this 14 only, or needs backporting to 13?

MorrisJobke
MorrisJobke requested changes Feb 8, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎 we should make it compatible to stable12, 13 and master and this I would go for another else branch in case the string starts with an underscore. Or does that make no sense, because we backport the same translations to all stable branches anyway?

@rullzer rullzer mentioned this pull request Feb 8, 2018
Merged
1 task
@nickvergessen
Copy link
Member

nickvergessen commented Feb 8, 2018

👎 we should make it compatible to stable12, 13 and master and this I would go for another else branch in case the string starts with an underscore. Or does that make no sense, because we backport the same translations to all stable branches anyway?

Not sure what you are refering to. This app has stableX branches and seperate releases for each supported version anyway?

@MorrisJobke
Copy link
Member

MorrisJobke commented Feb 8, 2018

Not sure what you are refering to. This app has stableX branches and seperate releases for each supported version anyway?

🙈 Okay - let's do it 👍

@MorrisJobke MorrisJobke merged commit eeb38fa into master Feb 8, 2018
@MorrisJobke MorrisJobke deleted the fix_lang_selector branch February 8, 2018 10:01
@Wastel Wastel mentioned this pull request Apr 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

No one assigned

Labels

3. to review enhancement

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer @nickvergessen @MorrisJobke