Add hint to settings #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardt
requested review from
LukasReschke,
MorrisJobke,
karlitschek and
nickvergessen
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
That's what the description is for...
nickvergessen
requested changes
Apr 27, 2017
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
That's what the description is for...
Member
Author
|
@nickvergessen I disagree, see nextcloud/server#4540 (comment) |
Member
|
I could not find where this is added. The little "i" in the admin settings section of access control does only show "open in documentation" |
Member
Author
|
@MorrisJobke it needed the server PR to be merged. Update server to master and you will see it there :) |
Member
|
@jancborchardt Please check the tests before merging code. You broke them. This is bad. Thank you. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more hints to settings, ref nextcloud/server#4478 nextcloud/server#4540
Please review @karlitschek @nickvergessen @MorrisJobke @LukasReschke