fix: Use icons instead of avatar for locking indication #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Knorr <jus@bitgrid.net>
Member
|
Hi @juliusknorr thanks for that ! I think that your 4 scenarios' icons are relevant. Let's see what the others think. |
Member
|
I also think the icons are appropriate. Is there a tooltip that informs users about why the file is locked? |
Member
Author
|
Yes, we can probably improve the tooltip wording a bit as well. |
Member
Author
|
Went for those three (with example users/clients):
|
Signed-off-by: Julius Knorr <jus@bitgrid.net>
jancborchardt
approved these changes
Dec 19, 2024
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Nice, looks good to me! :)
max-nextcloud
approved these changes
Dec 19, 2024
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #350
This would be my proposal based on the discussion in the ticket and with @jancborchardt
@marcoambrosini @Jerome-Herbinet I would be very interested in your feedback on this one.
File is manually locked by myself
File is locked manually by another user
File has a collaborative automated lock by text/office (e.g. others are editing it collaboratively right now)
File is locked automatically by a desktop client or webdav client