Skip to content

fix(notifications): Notifier::prepare() threw \InvalidArgumentExcepti… #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Jan 20, 2025
Merged

fix(notifications): Notifier::prepare() threw \InvalidArgumentExcepti… #692

nickvergessen merged 1 commit into from
Jan 20, 2025

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Dec 20, 2024

…on which is deprecated

If a user has any notifications this log is generated all the time:

OCA\…\Notification\Notifier::prepare() threw \InvalidArgumentException which is deprecated. Throw \OCP\Notification\UnknownNotificationException when the notification is not known to your notifier and otherwise handle all \InvalidArgumentException yourself.

@nickvergessen
fix(notifications): Notifier::prepare() threw \InvalidArgumentExcepti…
823092d 
…on which is deprecated

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen self-assigned this Dec 20, 2024
@nickvergessen nickvergessen merged commit 43dad0b into master Jan 20, 2025
44 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/notification-handling branch January 20, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud max-nextcloud is a code owner

Assignees

@nickvergessen nickvergessen

Labels

3. to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nickvergessen