[stable13] Do not keep FileInfoModels returned by "getModelForFile" #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FileInfoModels returned by "getModelForFile" are just temporary, and they should be used and forgotten instead of being kept by apps. It is not guaranteed that different calls to "getModelForFile" for the same file returns the same FileInfoModel object, so changes in one model instance could be not known by other model instances (and their views), and this could lead to different bugs (for example, a file list entry being duplicated when a text file is edited or favourited after being created). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
rullzer
approved these changes
Feb 17, 2018
rullzer
deleted the
stable13-88-do-not-keep-fileinfomodels-returned-by-getmodelforfile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #88