Skip to content

fix: Fix focus lost to body when closing firstrunwizard #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Pytal merged 2 commits into from
Feb 2, 2024
Merged

fix: Fix focus lost to body when closing firstrunwizard #1073

Pytal merged 2 commits into from
Feb 2, 2024

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Feb 1, 2024

Pytal added 2 commits February 1, 2024 11:55
@Pytal
fix: Fix focus lost to body when closing firstrunwizard
99d0777 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: compile assets
5c0fe11 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added this to the Nextcloud 29 milestone Feb 1, 2024
@Pytal Pytal self-assigned this Feb 1, 2024
@Pytal
Copy link
Member Author

Pytal commented Feb 1, 2024

/backport 99d0777 to stable28

@Pytal Pytal enabled auto-merge February 1, 2024 23:14
@szaimen
Copy link
Collaborator

szaimen commented Feb 2, 2024

I tested this and it doesnt seem to work since the menu seems to close when you open the firstrunwizard:

recordedVideo2024-02-02-124820.mp4

JuliaKirschenheuter
JuliaKirschenheuter approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my eyes it works well, thank you!

But actually this app is disabled and it was decided to leave firstrunwizard disabled

@Pytal Pytal merged commit ba1023c into master Feb 2, 2024
@Pytal Pytal deleted the fix/a11y/wizard-modal-return-focus branch February 2, 2024 13:31
@backportbot backportbot bot mentioned this pull request Feb 2, 2024
Merged
1 task
@Pytal
Copy link
Member Author

Pytal commented Feb 2, 2024

I tested this and it doesnt seem to work since the menu seems to close when you open the firstrunwizard:

Maybe not intuitive but the menu is supposed to close and the focus returns to the avatar button

But actually this app is disabled and it was decided to leave firstrunwizard disabled

Right!

@szaimen
Copy link
Collaborator

szaimen commented Feb 2, 2024

Maybe not intuitive but the menu is supposed to close and the focus returns to the avatar button

Yes, definitely not intuitive. Shouldnt the menu stay open?

@Pytal
Copy link
Member Author

Pytal commented Feb 2, 2024

Yes, definitely not intuitive. Shouldnt the menu stay open?

Nope, was discussed already that only when the menu is open it retains focus and is otherwise closed for a11y

@szaimen
Copy link
Collaborator

szaimen commented Feb 2, 2024

Yes, definitely not intuitive. Shouldnt the menu stay open?

Nope, was discussed already that only when the menu is open it retains focus and is otherwise closed for a11y

All right

@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@Pytal Pytal

Labels

3. to review accessibility bug

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

[BITV] Focus is lost to body when closing firstrunwizard

4 participants

@Pytal @szaimen @JuliaKirschenheuter