Skip to content

Increase description length #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jotoeri merged 1 commit into from
Jul 30, 2020
Merged

Increase description length #533

jotoeri merged 1 commit into from
Jul 30, 2020

Conversation

@jotoeri
Copy link
Member

@jotoeri jotoeri commented Jul 29, 2020

Ok, just did it now... 😋
Fixes #529

@jotoeri jotoeri added enhancement New feature or request 3. to review Waiting for reviews feature: 📑 form creation labels Jul 29, 2020
@jotoeri jotoeri added this to the 2.1 milestone Jul 29, 2020
@skjnldsv skjnldsv requested a review from nickvergessen July 30, 2020 07:23
@skjnldsv skjnldsv modified the milestones: 2.1, 2.0.2 Jul 30, 2020
@nickvergessen
Copy link
Member

nickvergessen commented Jul 30, 2020

Just make sure there is no attempt of an index on that column.

@jotoeri
Copy link
Member Author

jotoeri commented Jul 30, 2020

There is no index on description 👍

@skjnldsv @jancborchardt Just thought about, as we are changing lengths anyways, if we should also increase the length of the answers, too? As in #527 there was already somebody having a answer on long-text-question, longer than 2048 chars? Or even look at all sizes again? 🤔

jotoeri
jotoeri commented Jul 30, 2020
View reviewed changes
lib/Controller/PageController.php Outdated
Comment on lines 87 to 92
private $maxStringLengths = [
'formTitle' => 256,
'formDescription' => 2048,
'formDescription' => 8192,
'questionText' => 2048,
'optionText' => 1024,
'answerText' => 2048,
Copy link
Member Author

@jotoeri jotoeri Jul 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...these lengths are currently set.

@skjnldsv
Copy link
Member

skjnldsv commented Jul 30, 2020

As in #527 there was already somebody having a answer on long-text-question, longer than 2048 chars? Or even look at all sizes again?

Sure 👍
4096?

@jotoeri
Increase description length
726a405 
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@jotoeri jotoeri force-pushed the enh/description_length branch from 0440045 to 726a405 Compare July 30, 2020 11:21
@jotoeri
Copy link
Member Author

jotoeri commented Jul 30, 2020

Done 👍 The other lengths are good for you?
Also changed the old migration now, to not cut the answers and then increase the lengths again for those who did not update yet. Should work in this case to backward-change the migration.

@skjnldsv
Copy link
Member

skjnldsv commented Jul 30, 2020 •
edited
Loading

Done The other lengths are good for you?

Seems good to me 🤷
Merge and release?

@jotoeri jotoeri merged commit fc2f4d7 into master Jul 30, 2020
@jotoeri jotoeri deleted the enh/description_length branch July 30, 2020 11:26
@jancborchardt
Copy link
Member

jancborchardt commented Jul 31, 2020

@jotoeri good stuff! :) And yes, if there are any further issues with sizes, people will report it and we can adjust again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement New feature or request feature: 📑 form creation

Projects

None yet

Milestone

2.0.2

Development

Successfully merging this pull request may close these issues.

Increase the size of the form description field (allow longer text)

5 participants

@jotoeri @nickvergessen @skjnldsv @jancborchardt