Skip to content
This repository was archived by the owner on Nov 1, 2020. It is now read-only.

Conversation

@tnyeanderson
Copy link
Contributor

@tnyeanderson tnyeanderson commented May 29, 2019

Fixes: #438

Licence: MIT or AGPL

Description

Supports blacklisting folders by creating a .noimage file.

Features

  • .noimage functionality

Screenshots or screencasts

Caveats

Tests

Tested on my system

Test plan

Tested on

  • Windows/Firefox
  • Android 6.1/Chrome

TODO

Check list

  • Code is properly documented
  • Code is properly formatted
  • Commits have been squashed
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

Reviewers

Signed-off-by: Thomas Anderson <me@thomasanderson.cloud>
Signed-off-by: Thomas Anderson <me@thomasanderson.cloud>
@tnyeanderson
Copy link
Contributor Author

Why did travis-ci fail?

Signed-off-by: Thomas Anderson <me@thomasanderson.cloud>
@nickvergessen
Copy link
Member

Why is .nomedia not enough?

You can ignore failing travis CI for now.

@tnyeanderson
Copy link
Contributor Author

tnyeanderson commented Jun 21, 2019

Because .nomedia is used by so many apps/scanners, it can have undesirable effects. For instance, I may have a folder for a music album that contains mp3 files and an image for the album cover. If I use .nomedia because I don't want the image to appear in the gallery, the mp3 files won't appear in any music playing apps either because the whole folder will be ignored. It is nice to have an app-specific option to ignore a folder rather than trying to use such a global indicator to do it, potentially messing up other parts of your workflow.

Hope this explains the need.

@nickvergessen
Copy link
Member

Yeah sounds good 👍

@tnyeanderson
Copy link
Contributor Author

Can you approve? :)

@tnyeanderson
Copy link
Contributor Author

Thank you for the excellent suggestions! Will have to wait until I get home to commit the new changes. Will you have to reapprove once I do that? Would love to get this out of my queue......

@blizzz
Copy link
Member

blizzz commented Jun 27, 2019

I think we can merge once the requested changes are in

Signed-off-by: Thomas Anderson <me@thomasanderson.cloud>
@tnyeanderson
Copy link
Contributor Author

Sorry for the delay, the day job caught up to me this week :)

@nickvergessen nickvergessen merged commit 023d89f into nextcloud:master Jun 28, 2019
@nickvergessen
Copy link
Member

/backport to stable16

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Jun 28, 2019
@backportbot-nextcloud
Copy link

backport to stable16 in #533

@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an alias for .nomedia

3 participants