refactor(MountProvider): Small optimizations

[solracsf]

No description provided.

[come-nc]

I’m afraid this may be less efficient, it will expand the whole array into function parameters instead of passing 2 arrays to array_merge. Do you have a reference on why this would be better?

[solracsf]

Each call to array_merge() creates a new array by copying all existing elements plus the new ones. array_push() with the spread operator ... appends elements directly to the existing array without creating copies.

However, you might be right that spreading into function parameters isn't ideal.
The optimal approach may be to collect arrays first, then merge once:

$chunks = [];
foreach (array_chunk($pathHashes, 1000) as $chunk) {
	$query->setParameter('chunk', $chunk, IQueryBuilder::PARAM_STR_ARRAY);
	$chunks[] = $query->executeQuery()->fetchAll(\PDO::FETCH_COLUMN);
}
$paths = array_merge(...$chunks);