Force-load theme at the right moment #724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that the group manager is implicitly triggering the loading routine for the theme namespace, but that one is not available yet at this stage. The fix is to force load the theme app so that the namespace is available early enough when needed. This fixes an issue where the theme was not appearing for guest users. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
added
bug
juliusknorr
approved these changes
Aug 24, 2021
|
How to install above ? |
Member
|
Released as 2.0.2 |
|
@juliushaertl Where is 2.0.2 ? do we use "git pull" ? |
Member
|
Its on the app store and will get to your instance when it refetches the updates |
|
@juliushaertl Thank you for your support |
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #719
It seems that the group manager is implicitly triggering the loading
routine for the theme namespace, but that one is not available yet at
this stage.
The fix is to force load the theme app so that the namespace is
available early enough when needed.
This fixes an issue where the theme was not appearing for guest users.
Tests:
loadApp()doesn't load if disabled)