notify impersonated user with a notification and an email#84
notify impersonated user with a notification and an email#84cagdasbas wants to merge 7 commits intonextcloud:masterfrom
Conversation
|
I think a notification is enough for now. Otherwise I'm fine with the approach |
My thought was the same at first. But as soon as the admin user impersonates another, he/she can delete the notification. The user will only see it if already logged in at the moment. That's why I decided to add email notification. How about deleting the email and adding an event to the activities of the user? |
Let me fix that instead. |
Sure. I'm removing the email then? |
Yeah, sorry for the huge delay |
|
Patch for notifications is at nextcloud/notifications#550 |
Signed-off-by: Çağdaş Baş <cagdas@ouva.co>
Signed-off-by: Çağdaş Baş <cagdas@ouva.co>
Signed-off-by: Çağdaş Baş <cagdas@ouva.co>
Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Çağdaş Baş <cagdas@ouva.co>
Co-Authored-By: Sascha Wiswedel <wiswedel@users.noreply.github.com> Signed-off-by: Çağdaş Baş <cagdas@ouva.co>
blizzz
left a comment
There was a problem hiding this comment.
- would be good to have the test related changes in a different PR
- translations do not go in via github, but transifex
Signed-off-by: Çağdaş Baş <cagdasbs@ouva.co>
Attempt to solve #80
Notifier and mailer are mostly from quota_warning. A dirty hack but I'm willing to clean up with your feedback.