Skip to content

[BREAKING] feat: support nc33 breaking changes#952

Merged
saw-jan merged 9 commits intomasterfrom
feat/support-nc33-breaking-changes
Jan 29, 2026
Merged

[BREAKING] feat: support nc33 breaking changes#952
saw-jan merged 9 commits intomasterfrom
feat/support-nc33-breaking-changes

Conversation

@saw-jan
Copy link
Collaborator

@saw-jan saw-jan commented Jan 22, 2026 •
edited
Loading

Description

Adjust to breaking changes in NC 33 files API.

Similar to nextcloud/approval#350 and nextcloud/approval#355

Changes:

  • Updated @nextcloud/files to 4.0.0-rc.0
  • Set min. NC version to 33
  • support new files API

Steps to test

  1. Start Nextcloud 33
  2. Enable integration_openproject app version 3.0.0-alpha.1
  3. Check:
    • Batch action: Link to work package
      Screenshot from 2026-01-26 11-58-12
    • File context menu items: OpenProject and Link to work package
      Check OpenProject opens the sidebar tab
      Screenshot from 2026-01-26 11-58-54
    • OpenProject sidebar tab
      Screenshot from 2026-01-26 11-59-33

Related Issue or Workpackage

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Updated CHANGELOG.md file

@saw-jan saw-jan self-assigned this Jan 22, 2026
artonge
artonge reviewed Jan 22, 2026
View reviewed changes
@artonge artonge force-pushed the feat/support-nc33-breaking-changes branch from 0c9f65d to abb6961 Compare January 22, 2026 14:17
artonge
artonge approved these changes Jan 22, 2026
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and can confirm that the action and sidebar are properly registered.

@saw-jan saw-jan force-pushed the feat/support-nc33-breaking-changes branch from abb6961 to 5715384 Compare January 23, 2026 06:02
@saw-jan saw-jan force-pushed the feat/support-nc33-breaking-changes branch from 991e5c2 to a6c4686 Compare January 23, 2026 08:49
@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jan 23, 2026

Nice work @saw-jan 🎉

I added bea8cc7 fixing the copyright holder (material icons = google, OpenProject logo = OpenProject), cause it was mixed in the toml file :)

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jan 23, 2026

Looking forward to a pre-release published 🚀

@saw-jan
Copy link
Collaborator Author

saw-jan commented Jan 23, 2026

Nice work @saw-jan 🎉

I added bea8cc7 fixing the copyright holder (material icons = google, OpenProject logo = OpenProject), cause it was mixed in the toml file :)

THank you @AndyScherzinger for the fix. I will make this ready for ready once I confirm that all features are working

saw-jan
saw-jan commented Jan 23, 2026
View reviewed changes
@saw-jan saw-jan force-pushed the feat/support-nc33-breaking-changes branch from feb0f64 to c23dbf6 Compare January 23, 2026 11:35
saw-jan
saw-jan commented Jan 26, 2026
View reviewed changes
@saw-jan saw-jan force-pushed the feat/support-nc33-breaking-changes branch from c23dbf6 to ff89e7a Compare January 26, 2026 05:04
@saw-jan saw-jan marked this pull request as ready for review January 26, 2026 06:17
@saw-jan saw-jan mentioned this pull request Jan 26, 2026
Closed
8 tasks
@saw-jan
chore: bump minimum NC version to 33
33545f6 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
saw-jan and others added 8 commits January 28, 2026 09:42
@saw-jan
fix(file-actions): use object destructuring as per the new files API
f7fcb0e 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan
fix(file-actions): migrate sidebar tab registion to new API
2cc8ecc 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Louis Chmn <louis@chmn.me>
@saw-jan
fix: use normalized svg file
ca13b9d 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan
chore: bump version to 3.0.0-alpha.1
c0be68f 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan
chore: fix reuse compliance
7fd9f34 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan
chore: add changelog entry
aefa225 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@AndyScherzinger @saw-jan
fix(reuse): Fix copyright holder (flipped)
a6ff338 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@saw-jan
fix: open sidebar from file context menu
f6fd2a4 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan saw-jan force-pushed the feat/support-nc33-breaking-changes branch from ff89e7a to f6fd2a4 Compare January 28, 2026 04:08
@saw-jan saw-jan requested a review from susnux January 28, 2026 04:09
@github-actions
Copy link

github-actions bot commented Jan 28, 2026

JS Code Coverage

Coverage after merging feat/support-nc33-breaking-changes into master will be
91.17%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   adminSettings.js0%0%0%0%1, 1, 10–19, 2–9
   bootstrap.js0%0%0%0%1, 1, 10–12, 2–9
   dashboard.js0%0%0%0%1, 1, 10–19, 2–9
   fileActions.js0%0%0%0%1, 1, 10–19, 2, 20–23, 3–9
   personalSettings.js0%0%0%0%1, 1, 10–19, 2–9
   projectTab.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50, 6–9
   reference.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–45, 5–9
   utils.js85.92%33.33%50%87.59%12–20, 23–32
src/api
   endpoints.js100%100%100%100%
   settings.js64.71%100%0%73.33%10–11, 14–15
src/components
   AdminSettings.vue96.06%94.74%97.10%96.19%1003–1005, 1025–1028, 568, 568–569, 569, 606–612, 715–716, 720–721, 724–725, 729–730, 740–745, 788–790, 802–805, 818–820, 842–844, 927–929, 964–967
   ErrorLabel.vue100%100%100%100%
   OAuthConnectButton.vue91.85%75%100%93.28%64–69, 72–76
   PersonalSettings.vue92.02%95.65%90%91.71%133–134, 144–149, 152–161
src/components/admin
   FieldValue.vue100%100%100%100%
   FormAuthMethod.vue98.12%96.88%100%98.12%222–224, 247–250
   FormHeading.vue100%100%100%100%
   FormOpenProjectHost.vue98.87%94.74%100%99.34%167–169, 279
   FormSSOSettings.vue98.57%97.18%96.55%98.91%231–233, 242–243, 358–359
   TermsOfServiceUnsigned.vue100%100%100%100%
   TextInput.vue100%100%100%100%
src/components/icons
   ClippyIcon.vue100%100%100%100%
   OpenProjectIcon.vue100%100%100%100%
src/components/settings
   CheckBox.vue100%100%100%100%
   ErrorNote.vue100%100%100%100%
   SettingsTitle.vue96.91%85.71%100%97.67%51–53
src/components/tab
   EmptyContent.vue96.45%80.95%100%98.24%102–105, 107–108, 97
   SearchInput.vue95.32%92.96%94.74%95.79%139–140, 193, 204–209, 268–270, 286–288, 292–297
   WorkPackage.vue86.25%73.17%93.33%87.62%107–116, 129–131, 142–146, 156–158, 176–182, 220, 220–225, 225, 225–236, 81–82
src/constants
   appID.js100%100%100%100%
   links.js100%100%100%100%
   messages.js100%100%100%100%
src/filesPlugin
   filesPlugin.js0%0%0%0%1, 1, 10, 100, 11–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–99
   filesPluginLessThan28.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70, 8–9
src/utils
   workpackageHelper.js93.80%93.10%88.89%94.24%100–102, 23–27, 54, 54–56, 97–99
src/views
   CreateWorkPackageModal.vue94.12%86.21%90.48%95.38%374–379, 382, 398, 499–502, 507–512, 517–522, 528–531, 534, 550, 550, 591–595, 605–607, 630–631, 639–641, 670–672, 694–696, 705–709
   Dashboard.vue92.96%92.86%82.61%93.77%120–125, 134, 144, 147, 158–160, 214–217, 220–221, 228–232, 67
   LinkMultipleFilesModal.vue99.14%97.56%100%99.32%157–159
   ProjectsTab.vue94.06%92.45%93.33%94.33%100–101, 107–109, 129, 140–141, 175–185, 234–236, 98–99

@github-actions
Copy link

github-actions bot commented Jan 28, 2026

PHP Code Coverage

Coverage after merging feat/support-nc33-breaking-changes into master will be
66.67%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
integration_openproject/server/apps/integration_openproject/lib
   Capabilities.php0%100%0%0%24, 31–40
   OIDCClientMapper.php0%100%0%0%29, 40–49, 52
   TokenEventFactory.php100%100%100%100%
integration_openproject/server/apps/integration_openproject/lib/AppInfo
   Application.php36.59%100%50%35.53%105–107, 110–114, 116–121, 123–124, 127, 132–133, 135–138, 140, 142, 144, 148–151, 153–164, 166, 169, 173, 177–179, 212
integration_openproject/server/apps/integration_openproject/lib/BackgroundJob
   RemoveExpiredDirectUploadTokens.php0%100%0%0%28, 30–32, 41–42
integration_openproject/server/apps/integration_openproject/lib/Controller
   ConfigController.php75.12%100%64.71%75.56%114, 151–152, 154, 156–158, 160–163, 166–167, 169, 194, 198–200, 442–444, 446–448, 497, 541–543, 577–581, 592, 606–609, 617, 621–624, 660, 663–678, 695–700, 702–703, 705–707, 710, 712–728, 742–745, 747–751
   DirectDownloadController.php0%100%0%0%33–35, 50–52, 54–61
   DirectUploadController.php71.03%100%100%70.21%117–119, 162–164, 175, 179–182, 184, 194, 201, 217–219, 221–222, 225–230, 233, 235, 245–247, 253–255, 263–265, 280–282, 301, 306, 312
   FilesController.php86.99%100%83.33%87.18%178–179, 241, 250, 267–270, 275–277, 282–284, 293
   OpenProjectAPIController.php80.51%100%82.35%80.34%107, 146, 193–195, 198–205, 207–211, 213, 232, 257, 322, 372, 392, 439, 464–466, 469–473, 475, 66
   OpenProjectController.php96.45%100%80%96.95%241–245
integration_openproject/server/apps/integration_openproject/lib/Dashboard
   OpenProjectWidget.php0%100%0%0%101, 108–109, 111–116, 118–122, 124–126, 129–140, 61–66, 73, 80, 87, 94
integration_openproject/server/apps/integration_openproject/lib/Exception
   OpenprojectAvatarErrorException.php100%100%100%100%
   OpenprojectErrorException.php100%100%100%100%
   OpenprojectFileNotUploadedException.php100%100%100%100%
   OpenprojectGroupfolderSetupConflictException.php100%100%100%100%
   OpenprojectResponseException.php100%100%100%100%
   OpenprojectUnauthorizedUserException.php0%100%0%0%21
integration_openproject/server/apps/integration_openproject/lib/Listener
   BeforeGroupDeletedListener.php100%100%100%100%
   BeforeNodeInsideOpenProjectGroupfilderChangedListener.php0%100%0%0%46–48, 52–55, 57, 59, 62–63, 65, 67–70, 72–75, 77–79
   BeforeUserDeletedListener.php0%100%0%0%30, 37–38, 40–43, 45
   LoadAdditionalScriptsListener.php0%100%0%0%37–38, 46–47, 49, 51–52, 54
   LoadSidebarScript.php65.91%100%100%64.29%105, 77–88, 95, 98
   OpenProjectReferenceListener.php0%100%0%0%45–47, 54–55, 57, 59–60, 62–74
   TermsOfServiceEventListener.php0%100%0%0%41–42, 47–48, 50–51, 53–55, 58–62
   UserChangedListener.php0%100%0%0%34, 41–42, 45–50, 53
integration_openproject/server/apps/integration_openproject/lib/Migration
   Version2001Date20221213083550.php0%100%0%0%30, 40–48, 50–58, 60–62, 64
   Version20100Date20250820101358.php0%100%0%0%38, 47–53, 56
   Version2310Date20230116153411.php0%100%0%0%29, 32–35, 37–62, 64–65, 67
   Version2400Date20230504144300.php0%100%0%0%30, 40–43
   Version2640Date20240628114301.php0%100%0%0%35, 47–49, 52–53, 56
   Version2900Date20250718065820.php0%100%0%0%23, 35–38, 40–41, 43–44, 47
integration_openproject/server/apps/integration_openproject/lib/Reference
   WorkPackageReferenceProvider.php51.67%100%25%58.33%100–101, 104, 108, 142, 150–151, 159, 37, 44, 51, 58–60, 87, 93–96, 99
integration_openproject/server/apps/integration_openproject/lib/Search
   OpenProjectSearchProvider.php0%100%0%0%100–102, 104–106, 109–110, 112–113, 116–125, 127–131, 52–55, 62, 69, 77, 79, 82, 89–90, 93–97, 99
   OpenProjectSearchResultEntry.php100%100%100%100%
integration_openproject/server/apps/integration_openproject/lib/Service
   DatabaseService.php42.31%100%60%40.43%108–112, 114, 63–76, 78–85
   DirectDownloadService.php88.46%100%100%87.50%62–63, 65
   DirectUploadService.php42.86%100%66.67%40%101, 62–65, 67–75, 95
   OauthService.php0%100%0%0%100–101, 40–42, 51–58, 60–66, 75–83, 94–99
   OpenProjectAPIService.php74.53%100%75.71%74.43%1011–1017, 1019–1026,

nabim777
nabim777 approved these changes Jan 29, 2026
View reviewed changes
Copy link
Collaborator

@nabim777 nabim777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@saw-jan saw-jan merged commit 5bbabe4 into master Jan 29, 2026
12 checks passed
@saw-jan saw-jan deleted the feat/support-nc33-breaking-changes branch January 29, 2026 06:14
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@susnux susnux susnux approved these changes

@nabim777 nabim777 nabim777 approved these changes

@julien-nc julien-nc Awaiting requested review from julien-nc julien-nc is a code owner

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@ba1ash ba1ash Awaiting requested review from ba1ash ba1ash is a code owner

@dominic-braeunlein dominic-braeunlein Awaiting requested review from dominic-braeunlein dominic-braeunlein is a code owner

@Kharonus Kharonus Awaiting requested review from Kharonus Kharonus is a code owner

@lindenthal lindenthal Awaiting requested review from lindenthal lindenthal is a code owner

@psatyal psatyal Awaiting requested review from psatyal psatyal is a code owner

@wielinde wielinde Awaiting requested review from wielinde wielinde is a code owner

@NobodysNightmare NobodysNightmare Awaiting requested review from NobodysNightmare NobodysNightmare is a code owner

@artonge artonge Awaiting requested review from artonge

Assignees

@saw-jan saw-jan

Labels

3. to review feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@saw-jan @AndyScherzinger @susnux @artonge @nabim777